SUSE/saptune

View on GitHub

Showing 64 of 74 total issues

Function GetSolutionDefintion has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func GetSolutionDefintion(solsDir, extraDir, noteDir string) map[string]map[string]Solution {
    sols := make(map[string]map[string]Solution)
    sol := make(map[string]Solution)
    currentArch := ""
    arch := ""
Severity: Minor
Found in sap/solution/solution.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getInfoTxt has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func getInfoTxt(action string, state bool) (string, string, bool, bool) {
    sinfo := ""

    active, err := system.SystemctlIsRunning(SaptuneService)
    if err != nil {
Severity: Minor
Found in actions/serviceacts.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def main():

    # Check if FORCE is set.
    try:
        if os.environ['FORCE'] != '1':
Severity: Minor
Found in ospackage/usr/share/saptune/schemas/1.0/templates/build.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function chkBlkTags has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func chkBlkTags(info, tagField string, secFields, actbdev []string) (bool, []string) {
    ret := false
    info = strings.TrimPrefix(info, "blk")
    tagExpr := fmt.Sprintf(".*%s.*", tagField)
    // vendor or model
Severity: Minor
Found in txtparser/tags.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language