Sign upLogin

SUSE/saptune

View on GitHub
Star
sap/note/ini.go

Summary

Maintainability
B
6 hrs
Test Coverage
C
76%

Method INISettings.Optimise has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (vend INISettings) Optimise() (Note, error) {
    blckOK := make(map[string][]string)
    scheds := ""
    next := false
Severity: Major
Found in sap/note/ini.go - About 2 hrs to fix

    Method INISettings.Initialise has 70 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (vend INISettings) Initialise() (Note, error) {
    ini, err := txtparser.GetSectionInfo("sns", vend.ID, false)
    if err != nil {
        // Parse the configuration file
        ini, err = txtparser.ParseINIFile(vend.ConfFilePath, false)
    Severity: Minor
    Found in sap/note/ini.go - About 1 hr to fix

      Method INISettings.Apply has 66 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (vend INISettings) Apply() error {
    var err error
    errs := make([]error, 0)
    revertValues := false
    pvendID := vend.ID
      Severity: Minor
      Found in sap/note/ini.go - About 1 hr to fix

        Method INISettings.Apply has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
        Open

        func (vend INISettings) Apply() error {
    var err error
    errs := make([]error, 0)
    revertValues := false
    pvendID := vend.ID
        Severity: Minor
        Found in sap/note/ini.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method INISettings.Optimise has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (vend INISettings) Optimise() (Note, error) {
    blckOK := make(map[string][]string)
    scheds := ""
    next := false
        Severity: Minor
        Found in sap/note/ini.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status