Sign upLogin

SUSE/saptune

View on GitHub
Star
sap/note/sectBlock.go

Summary

Maintainability
B
5 hrs
Test Coverage
B
88%

Function OptBlkVal has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func OptBlkVal(key, cfgval string, cur *param.BlockDeviceQueue, bOK map[string][]string) (string, string) {
    info := ""
    if cfgval == "" {
        return cfgval, info
    }
Severity: Minor
Found in sap/note/sectBlock.go - About 1 hr to fix

    Function SetBlkVal has 5 return statements (exceeds 4 allowed).
    Open

    func SetBlkVal(key, value string, cur *param.BlockDeviceQueue, revert bool) error {
    var err error

    switch {
    case system.IsSched.MatchString(key):
    Severity: Major
    Found in sap/note/sectBlock.go - About 35 mins to fix

      Function GetBlkVal has 5 return statements (exceeds 4 allowed).
      Open

      func GetBlkVal(key string, cur *param.BlockDeviceQueue) (string, string, error) {
    retVal := ""
    info := ""

    switch {
      Severity: Major
      Found in sap/note/sectBlock.go - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            case system.IsMsect.MatchString(key):
        newMsect, err := cur.BlockDeviceMaxSectorsKB.Inspect()
        if err != nil {
            return "", info, err
        }
        Severity: Minor
        Found in sap/note/sectBlock.go and 2 other locations - About 35 mins to fix
        sap/note/sectBlock.go on lines 29..36
        sap/note/sectBlock.go on lines 37..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            case system.IsRahead.MatchString(key):
        newRahead, err := cur.BlockDeviceReadAheadKB.Inspect()
        if err != nil {
            return "", info, err
        }
        Severity: Minor
        Found in sap/note/sectBlock.go and 2 other locations - About 35 mins to fix
        sap/note/sectBlock.go on lines 29..36
        sap/note/sectBlock.go on lines 45..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            case system.IsNrreq.MatchString(key):
        newNrR, err := cur.BlockDeviceNrRequests.Inspect()
        if err != nil {
            return "", info, err
        }
        Severity: Minor
        Found in sap/note/sectBlock.go and 2 other locations - About 35 mins to fix
        sap/note/sectBlock.go on lines 37..44
        sap/note/sectBlock.go on lines 45..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case system.IsRahead.MatchString(key):
        if revert {
            ival, _ := strconv.Atoi(value)
            cur.BlockDeviceReadAheadKB.ReadAheadKB[strings.TrimPrefix(key, "READ_AHEAD_KB_")] = ival
        }
        Severity: Minor
        Found in sap/note/sectBlock.go and 1 other location - About 30 mins to fix
        sap/note/sectBlock.go on lines 128..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case system.IsNrreq.MatchString(key):
        if revert {
            ival, _ := strconv.Atoi(value)
            cur.BlockDeviceNrRequests.NrRequests[strings.TrimPrefix(key, "NRREQ_")] = ival
        }
        Severity: Minor
        Found in sap/note/sectBlock.go and 1 other location - About 30 mins to fix
        sap/note/sectBlock.go on lines 137..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status