Sign upLogin

SUSE/saptune

View on GitHub
Star
system/cpu.go

Summary

Maintainability
C
1 day
Test Coverage
F
28%

Function SetForceLatency has a Cognitive Complexity of 62 (exceeds 20 allowed). Consider refactoring.
Open

func SetForceLatency(value, savedStates string, revert bool) error {
    oldState := ""

    if !supportsForceLatencySettings(value) {
        return nil
Severity: Minor
Found in system/cpu.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GetFLInfo has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func GetFLInfo() (string, string, bool) {
    lat := 0
    maxlat := 0
    supported := false
    savedStates := ""
Severity: Minor
Found in system/cpu.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GetFLInfo has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func GetFLInfo() (string, string, bool) {
    lat := 0
    maxlat := 0
    supported := false
    savedStates := ""
Severity: Minor
Found in system/cpu.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

        } else if currentCPUDriver() == "none" {
        WarningLog("Latency settings not supported by the system, no active cpuidle driver")
        setLatency = false
    }
    Severity: Major
    Found in system/cpu.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                      if FLFields[0] == cpuName && FLFields[1] == stateName {
                                    oldState = FLFields[2]
                                }
      Severity: Major
      Found in system/cpu.go - About 45 mins to fix

        Function SecureBootEnabled has 5 return statements (exceeds 4 allowed).
        Open

        func SecureBootEnabled() bool {
    var isSecBootFileName = regexp.MustCompile(`^SecureBoot-\w[\w-]+`)
    if _, err := os.Stat(efiVarsDir); os.IsNotExist(err) {
        InfoLog("no EFI directory '%+s' found, assuming legacy boot", efiVarsDir)
        return false
        Severity: Major
        Found in system/cpu.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status