SUSE/stratos

Method PostgresCNSIRepository.Update has 6 return statements (exceeds 4 allowed).

Open

func (p *PostgresCNSIRepository) Update(endpoint interfaces.CNSIRecord, encryptionKey []byte) error {
    log.Debug("Update endpoint")

    if endpoint.GUID == "" {
        msg := "Unable to update Endpoint without a valid guid."

Method UserFavorites.create has 6 return statements (exceeds 4 allowed).

Open

func (uf *UserFavorites) create(c echo.Context) error {

    store, err := userfavoritesstore.NewFavoritesDBStore(uf.portalProxy.GetDatabaseConnection())
    if err != nil {
        return interfaces.NewHTTPShadowError(

Method ConsoleConfigRepository.GetConsoleConfig has 6 return statements (exceeds 4 allowed).

Open

func (c *ConsoleConfigRepository) GetConsoleConfig() (*interfaces.ConsoleConfig, error) {
    log.Debug("Get ConsoleConfig")
    rows, err := c.db.Query(getConsoleConfig)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve console config record: %v", err)

Method CloudFoundrySpecification.openNoaaConsumer has 6 return statements (exceeds 4 allowed).

Open

func (c CloudFoundrySpecification) openNoaaConsumer(echoContext echo.Context) (*AuthorizedConsumer, error) {

    ac := &AuthorizedConsumer{}

    // Get the CNSI and app IDs from route parameters

Method CloudFoundrySpecification.cfLoginHook has 6 return statements (exceeds 4 allowed).

Open

func (c *CloudFoundrySpecification) cfLoginHook(context echo.Context) error {

    cfAPI, cfCnsi, err := c.fetchAutoRegisterEndpoint()
    // CF auto reg url missing, continue as normal
    if cfAPI == "" {

Function createPluginForEndpointType has 6 return statements (exceeds 4 allowed).

Open

func createPluginForEndpointType(endpointType string) GeneratedEndpointPlugin {
    log.Debugf("Generating plugin %s", endpointType)
    gep := GeneratedEndpointPlugin{}
    gep.endpointType = endpointType
    gep.subTypes = make(map[string]pluginConfig)

Method CustomBinder.bindData has 6 return statements (exceeds 4 allowed).

Open

func (b *CustomBinder) bindData(ptr interface{}, data map[string][]string, tag string) error {
    typ := reflect.TypeOf(ptr).Elem()
    val := reflect.ValueOf(ptr).Elem()

    if typ.Kind() != reflect.Struct {

Method portalProxy.DoRegisterEndpoint has 6 return statements (exceeds 4 allowed).

Open

func (p *portalProxy) DoRegisterEndpoint(cnsiName string, apiEndpoint string, skipSSLValidation bool, clientId string, clientSecret string, ssoAllowed bool, subType string, fetchInfo interfaces.InfoFunc) (interfaces.CNSIRecord, error) {

    if len(cnsiName) == 0 || len(apiEndpoint) == 0 {
        return interfaces.CNSIRecord{}, interfaces.NewHTTPShadowError(
            http.StatusBadRequest,

Function ApplyMigrations has 6 return statements (exceeds 4 allowed).

Open

func ApplyMigrations(conf *goose.DBConf, db *sql.DB) error {
    current, err := goose.EnsureDBVersion(conf, db)
    if err != nil {
        return fmt.Errorf("Failed to get database version: %s", err.Error())
    }

Method PostgresCNSIRepository.List has 6 return statements (exceeds 4 allowed).

Open

func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    log.Debug("List")
    rows, err := p.db.Query(listCNSIs)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)

Method portalProxy.setupSaveConfig has 6 return statements (exceeds 4 allowed).

Open

func (p *portalProxy) setupSaveConfig(c echo.Context) error {

    log.Debug("setupSaveConfig")

    consoleRepo, err := console_config.NewPostgresConsoleConfigRepository(p.DatabaseConnectionPool)

Method portalProxy.logoutOfCNSI has 6 return statements (exceeds 4 allowed).

Open

func (p *portalProxy) logoutOfCNSI(c echo.Context) error {
    log.Debug("logoutOfCNSI")

    cnsiGUID := c.Param("cnsi_guid")

Function init has 6 return statements (exceeds 4 allowed).

Open

func init() {
    RegisterMigration(20191008121900, "PrimaryKeys", func(txn *sql.Tx, conf *goose.DBConf) error {

        // Make sure all tokens have a CNSI guid
        ensureTokensHaveCnsi := "UPDATE tokens SET cnsi_guid='STRATOS' WHERE token_type='uaa' and cnsi_guid IS NULL;"

Consider simplifying this complex logical expression.

Open

    if (!secrets ||
      !secrets.consoleUsers || !secrets.consoleUsers.admin || !secrets.consoleUsers.nonAdmin ||
      !secrets.endpoints || !secrets.endpoints.cf
    ) {
      throw new Error(`Failed to validate secrets`);

Consider simplifying this complex logical expression.

Open

    if (isAdmin) {
      const allCfUsersAction = this.createCfGetAllUsersAction(cfGuid);

      if (!orgGuid) {
        return observableOf(allCfUsersAction);

Consider simplifying this complex logical expression.

Open

  if (ep.provider && ep.provider.metadata && ep.provider.metadata && ep.provider.metadata.metrics_stratos
    && Array.isArray(ep.provider.metadata.metrics_stratos)) {
    ep.provider.metadata.metrics_stratos.forEach(endp => {
      // See if we already know about this endpoint
      const hasEndpoint = data.findIndex(i => compareUrl(i.url, endp.url) || compareUrl(i.url, endp.cfEndpoint)) !== -1;

Consider simplifying this complex logical expression.

Open

    if (dsEndpointType || onlyConnected) {
      transformEntities.push((entities: EndpointModel[]) => {
        return dsEndpointType || onlyConnected ? entities.filter(endpoint => {
          return (!onlyConnected || endpoint.connectionStatus === 'connected') &&
            (!dsEndpointType || endpoint.cnsi_type === dsEndpointType);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package analysis

import (
    "database/sql"
    "strings"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package analysis

import (
    "database/sql"
    "strings"

• Read up
  Read up

Function newPortalProxy has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func newPortalProxy(pc interfaces.PortalConfig, dcp *sql.DB, ss HttpSessionStore, sessionStoreOptions *sessions.Options, env *env.VarSet) *portalProxy {