Sign upLogin

Sage/dynamodb_framework

View on GitHub
Star
lib/dynamodb_framework/dynamodb_table_manager.rb

Summary

Maintainability
C
1 day
Test Coverage
B
87%

File dynamodb_table_manager.rb has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module DynamoDbFramework
  class TableManager

    attr_reader :dynamodb
Severity: Minor
Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 3 hrs to fix

    Class TableManager has 22 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

      class TableManager

    attr_reader :dynamodb

    def initialize(store)
    Severity: Minor
    Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 2 hrs to fix

      Method create_table has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def create_table(options = {})

      if options[:name] == nil
        raise 'A valid table name must be specified.'
      end
      Severity: Major
      Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 2 hrs to fix

        Method create_table has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def create_table(options = {})

      if options[:name] == nil
        raise 'A valid table name must be specified.'
      end
        Severity: Minor
        Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def create(table_name, attributes, partition_key, range_key = nil, read_capacity = 20, write_capacity = 10, global_indexes = nil, billing_mode = 'PROVISIONED')

      if exists?(table_name)
        return
      end
        Severity: Minor
        Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 1 hr to fix

          Method create has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def create(table_name, attributes, partition_key, range_key = nil, read_capacity = 20, write_capacity = 10, global_indexes = nil, billing_mode = 'PROVISIONED')
          Severity: Major
          Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 1 hr to fix

            Method create_global_index has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def create_global_index(name, partition_key, range_key = nil, read_capacity = 20, write_capacity = 10, billing_mode = 'PROVISIONED')
            Severity: Minor
            Found in lib/dynamodb_framework/dynamodb_table_manager.rb - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def drop(table_name)

      if !exists?(table_name)
        return
      end
              Severity: Minor
              Found in lib/dynamodb_framework/dynamodb_table_manager.rb and 1 other location - About 35 mins to fix
              lib/dynamodb_framework/dynamodb_table_manager.rb on lines 439..447

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def drop_table(table_name)

      if !exists?(table_name)
        return
      end
              Severity: Minor
              Found in lib/dynamodb_framework/dynamodb_table_manager.rb and 1 other location - About 35 mins to fix
              lib/dynamodb_framework/dynamodb_table_manager.rb on lines 428..436

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status