Sign upLogin

Sakuten/backend

View on GitHub
Star
api/auth.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function login_required has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

def login_required(*required_authority):
    """
        a decorder to require login
        Args:
            *required_authority (str): required authorities
Severity: Minor
Found in api/auth.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function todays_user has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def todays_user(secret_id='', user_id=''):
    """confirm the user id isn't used in other day
        and return `User` object
        Args:
            secret_id (str): secret id of target user
Severity: Minor
Found in api/auth.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return auth_error(4, 'error="invalid_request"')
Severity: Major
Found in api/auth.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return auth_error(0, 'error="invalid_token"')
    Severity: Major
    Found in api/auth.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return auth_error(15, 'error="insufficient_scope"')
      Severity: Major
      Found in api/auth.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return auth_error(0, 'realm="id_disabled"')
        Severity: Major
        Found in api/auth.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return auth_error(0, 'realm="invalid_token"')
          Severity: Major
          Found in api/auth.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return f(*args, **kwargs)
            Severity: Major
            Found in api/auth.py - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status