SciRuby/distribution

View on GitHub

Showing 98 of 98 total issues

Method p_series has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def p_series(a, x, with_error = false)
          d = d(a, x, with_error)
          d, d_err = d if with_error
          sum      = 1.0
          term     = 1.0
Severity: Minor
Found in lib/distribution/math_extension/incomplete_gamma.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cdf_hull has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def cdf_hull(a, b, rho)
          # puts "a:#{a} - b:#{b} - rho:#{rho}"
          if a <= 0 && b <= 0 && rho <= 0
            # puts "ruta 1"
            aprime = a.quo(Math.sqrt(2.0 * (1.0 - rho**2)))
Severity: Minor
Found in lib/distribution/bivariatenormal/ruby.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            return x <= 1.0e+06 ? q_continued_fraction(a, x, with_error) : q_large_x(a, x, with_error)
Severity: Major
Found in lib/distribution/math_extension/incomplete_gamma.rb - About 45 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      module LogNormal
        module GSL_
          class << self
            def pdf(x, u, s)
              GSL::Ran.lognormal_pdf(x.to_f, u.to_f, s.to_f)
    Severity: Major
    Found in lib/distribution/lognormal/gsl.rb and 2 other locations - About 45 mins to fix
    lib/distribution/beta/gsl.rb on lines 2..26
    lib/distribution/gamma/gsl.rb on lines 2..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      module Beta
        module GSL_
          class << self
            # PDF.
            def pdf(x, a, b)
    Severity: Major
    Found in lib/distribution/beta/gsl.rb and 2 other locations - About 45 mins to fix
    lib/distribution/gamma/gsl.rb on lines 2..25
    lib/distribution/lognormal/gsl.rb on lines 2..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                if x > a - Math.sqrt(a)
                  return q_continued_fraction(a, x, with_error)
                else
                  p = p_series(a, x, with_error)
                  p, p_err = p if with_error
    Severity: Major
    Found in lib/distribution/math_extension/incomplete_gamma.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  scale_factor = scale ? Math.exp(x) : 1.0
      Severity: Major
      Found in lib/distribution/math_extension/exponential_integral.rb - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          module Gamma
            module GSL_
              class << self
                def pdf(x, a, b)
                  GSL::Ran.gamma_pdf(x.to_f, a.to_f, b.to_f)
        Severity: Major
        Found in lib/distribution/gamma/gsl.rb and 2 other locations - About 45 mins to fix
        lib/distribution/beta/gsl.rb on lines 2..26
        lib/distribution/lognormal/gsl.rb on lines 2..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method q_asymptotic_uniform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def q_asymptotic_uniform(a, x, with_error = false)
                  rta = Math.sqrt(a)
                  eps = (x - a).quo(a)
        
                  ln_term = Log.log_1plusx_minusx(eps, with_error)
        Severity: Minor
        Found in lib/distribution/math_extension/incomplete_gamma.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cdf has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def cdf(aa, bb, sigma, epsilon = 0.0001, alpha = 2.5, max_iterations = 100) # :nodoc:
        Severity: Minor
        Found in lib/distribution/normalmultivariate.rb - About 45 mins to fix

          Method create_distribution_methods has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def create_distribution_methods
                Distribution.libraries_order.each do |l_name|
                  if const_defined? l_name
                    l = const_get(l_name)
                    # Add methods from engine to base base, if not yet included
          Severity: Minor
          Found in lib/distribution/distributable.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method q_series has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def q_series(a, x, with_error = false)
                    term1 = nil
                    sum   = nil
                    term2 = nil
                    begin
          Severity: Minor
          Found in lib/distribution/math_extension/incomplete_gamma.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      result_c, result_c_err = result_c if with_error
          Severity: Major
          Found in lib/distribution/math_extension/exponential_integral.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      elsif x <= 4.0
                        s = 1.0 / x * (scale ? 1.0 : Math.exp(-x))
                        result_c = ChebyshevSeries.eval((8.0 / x - 5.0) / 3.0, :ae13, with_error)
                        result_c, result_c_err = result_c if with_error
                        result   = s * (1.0 + result_c)
            Severity: Major
            Found in lib/distribution/math_extension/exponential_integral.rb - About 45 mins to fix

              Method q_chi2 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def q_chi2(df, chi2)
                        chi2 = chi2.to_f
                        if (df & 1) != 0
                          chi = Math.sqrt(chi2)
              
              
              Severity: Minor
              Found in lib/distribution/chisquare/ruby.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                               c9 = -2.75573192239859e-6 *
                                    (-2.8243487670469080 + lnx) *
                                    (-2.3798494322701120 + lnx) *
                                    (-1.9143674728689960 + lnx) *
                                    (-1.3814529102920370 + lnx) *
              Severity: Minor
              Found in lib/distribution/math_extension/incomplete_gamma.rb and 1 other location - About 40 mins to fix
              lib/distribution/math_extension/incomplete_gamma.rb on lines 310..319

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                    c10 = -2.75573192239859e-7 *
                                          (-2.9540329644556910 + lnx) *
                                          (-2.5491366926991850 + lnx) *
                                          (-2.1348279229279880 + lnx) *
                                          (-1.6741881076349450 + lnx) *
              Severity: Minor
              Found in lib/distribution/math_extension/incomplete_gamma.rb and 1 other location - About 40 mins to fix
              lib/distribution/math_extension/incomplete_gamma.rb on lines 300..309

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method continued_fraction has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def continued_fraction(a, b, x, epsabs = nil, with_error = false)
              Severity: Minor
              Found in lib/distribution/math_extension/incomplete_beta.rb - About 35 mins to fix

                Method pdf has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def pdf(x, y, rho, s1 = 1.0, s2 = 1.0)
                Severity: Minor
                Found in lib/distribution/bivariatenormal/gsl.rb - About 35 mins to fix

                  Method axpy has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def axpy(aa, yy, a, b, x)
                  Severity: Minor
                  Found in lib/distribution/math_extension/incomplete_beta.rb - About 35 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language