SciRuby/minimization

View on GitHub
lib/minimization.rb

Summary

Maintainability
D
2 days
Test Coverage

Method brent_iterate has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def brent_iterate
      x_left = @x_lower;
      x_right = @x_upper;

      z = @x_minimum;
Severity: Minor
Found in lib/minimization.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File minimization.rb has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'multidim/brent_root_finder'
require_relative 'multidim/conjugate_gradient'
require_relative 'multidim/nelder_mead'
require_relative 'multidim/point_value_pair'
require_relative 'multidim/powell'
Severity: Minor
Found in lib/minimization.rb - About 4 hrs to fix

    Method brent_iterate has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def brent_iterate
          x_left = @x_lower;
          x_right = @x_upper;
    
          z = @x_minimum;
    Severity: Major
    Found in lib/minimization.rb - About 3 hrs to fix

      Method bracketing has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def bracketing
            eval_max=10
            f_left = @f_lower;
            f_right = @f_upper;
            x_left = @x_lower;
      Severity: Major
      Found in lib/minimization.rb - About 2 hrs to fix

        Method iterate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def iterate
              ax=@lower
              bx=@expected
              cx=@upper
              c = (3-Math::sqrt(5)).quo(2);
        Severity: Minor
        Found in lib/minimization.rb - About 1 hr to fix

          Method bracketing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def bracketing
                eval_max=10
                f_left = @f_lower;
                f_right = @f_upper;
                x_left = @x_lower;
          Severity: Minor
          Found in lib/minimization.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method iterate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def iterate
                ax=@lower
                bx=@expected
                cx=@upper
                c = (3-Math::sqrt(5)).quo(2);
          Severity: Minor
          Found in lib/minimization.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(lower, upper, proc, proc_1d, proc_2d)
          Severity: Minor
          Found in lib/minimization.rb - About 35 mins to fix

            Method iterate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def iterate
                  k=0
                  bracketing if @do_bracketing
                  while k<@max_iteration and (@x_lower-@x_upper).abs>@epsilon
                    k+=1
            Severity: Minor
            Found in lib/minimization.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method iterate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def iterate()
                  ax = @lower
                  cx = @upper
                  k = 0;
                  while (ax-cx).abs > @epsilon and k<@max_iteration
            Severity: Minor
            Found in lib/minimization.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return false
            Severity: Major
            Found in lib/minimization.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return true;
              Severity: Major
              Found in lib/minimization.rb - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status