Sciebo-RDS/py-research-data-services-common

View on GitHub
RDS/ROParser.py

Summary

Maintainability
B
5 hrs
Test Coverage
A
94%

Function getElement has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def getElement(self, id: str, doc: dict = None, expand: bool = False, clean: bool = False, clamps: int = None):
        """Gets the element with given id

        Args:
            id (str): The id you are searching for
Severity: Minor
Found in RDS/ROParser.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __clean has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def __clean(self, docs, clamps):
        if not isinstance(docs, (dict, list)):
            return docs

        if not isinstance(docs, list):
Severity: Minor
Found in RDS/ROParser.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def getElement(self, id: str, doc: dict = None, expand: bool = False, clean: bool = False, clamps: int = None):
Severity: Minor
Found in RDS/ROParser.py - About 35 mins to fix

    Function __getRootIdentifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def __getRootIdentifier(self):
            for elem in self.__doc["@graph"]:
    
                if elem["@id"] == "ro-crate-metadata.json":
                    version = elem["conformsTo"]["@id"]
    Severity: Minor
    Found in RDS/ROParser.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status