Sign upLogin

Sciebo-RDS/py-research-data-services-common

View on GitHub
Star
RDS/Service.py

Summary

Maintainability
D
2 days
Test Coverage
B
80%

File Service.py has 569 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from .Token import Token, OAuth2Token
from .User import User
from .Informations import LoginMode, FileTransferMode, FileTransferArchive
from urllib.parse import urlparse, urlunparse
import requests
Severity: Major
Found in RDS/Service.py - About 1 day to fix

    Function __init__ has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def __init__(
        self,
        servicename: str,
        implements: list = None,
        fileTransferMode: FileTransferMode = FileTransferMode.active,
    Severity: Minor
    Found in RDS/Service.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    BaseService has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BaseService:
    """
    Represents a service, which can be used in RDS.
    """
    Severity: Minor
    Found in RDS/Service.py - About 2 hrs to fix

      Function refresh has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def refresh(self, token: OAuth2Token):
        """
        Refresh the given oauth2 token for specified user.
        """
      Severity: Minor
      Found in RDS/Service.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in RDS/Service.py - About 1 hr to fix

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Minor
        Found in RDS/Service.py - About 45 mins to fix

          Function from_service has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def from_service(
          Severity: Minor
          Found in RDS/Service.py - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status