SebastianCzoch/onesky-go

View on GitHub
Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go

Summary

Maintainability
C
1 day
Test Coverage

File assertions.go has 535 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package assert

import (
    "bufio"
    "bytes"

    Function isEmpty has 6 return statements (exceeds 4 allowed).
    Open

    func isEmpty(object interface{}) bool {
    
        if object == nil {
            return true
        } else if object == "" {
    Severity: Major
    Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go - About 40 mins to fix

      Function InDelta has 5 return statements (exceeds 4 allowed).
      Open

      func InDelta(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool {
      
          af, aok := toFloat(expected)
          bf, bok := toFloat(actual)
      
      
      Severity: Major
      Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func InEpsilonSlice(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool {
            if expected == nil || actual == nil ||
                reflect.TypeOf(actual).Kind() != reflect.Slice ||
                reflect.TypeOf(expected).Kind() != reflect.Slice {
                return Fail(t, fmt.Sprintf("Parameters must be slice"), msgAndArgs...)
        Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go on lines 719..737

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 241.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func InDeltaSlice(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool {
            if expected == nil || actual == nil ||
                reflect.TypeOf(actual).Kind() != reflect.Slice ||
                reflect.TypeOf(expected).Kind() != reflect.Slice {
                return Fail(t, fmt.Sprintf("Parameters must be slice"), msgAndArgs...)
        Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go on lines 774..792

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 241.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 22 places. Go fmt your code!
        Open

        package assert

        There are no issues that match your filters.

        Category
        Status