SergioMadness/payment-laravel

View on GitHub
src/contracts/recurring/RecurringPayment.php

Summary

Maintainability
A
50 mins
Test Coverage

Method initPayment has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function initPayment(string $token, string $orderId, string $paymentId, float $amount, string $description, string $currency = PayService::CURRENCY_RUR_ISO, array $extraParams = []): bool;
Severity: Major
Found in src/contracts/recurring/RecurringPayment.php - About 50 mins to fix

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        public function setUserId(string $id): self;

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Line exceeds 120 characters; contains 199 characters
    Open

        public function initPayment(string $token, string $orderId, string $paymentId, float $amount, string $description, string $currency = PayService::CURRENCY_RUR_ISO, array $extraParams = []): bool;

    Expected 1 newline at end of file; 0 found
    Open

    }

    There are no issues that match your filters.

    Category
    Status