Sign upLogin

SergioMadness/php2wsdl

View on GitHub
Star

Showing 15 of 15 total issues

File WSDL.php has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace PHP2WSDL;

use DOMDocument;
Severity: Minor
Found in src/WSDL.php - About 4 hrs to fix

    Function addMethodToWsdl has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addMethodToWsdl(ReflectionMethod $method, DOMElement $port, DOMElement $binding)
    {
        $args = [];
        $annotations = [];
        $sequence = [];
    Severity: Minor
    Found in src/PHPClass2WSDL.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addComplexType has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public function addComplexType($type)
    {
        if (isset($this->includedTypes[$type])) {
            return $this->includedTypes[$type];
        }
    Severity: Minor
    Found in src/WSDL.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addMethodToWsdl has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addMethodToWsdl(ReflectionMethod $method, DOMElement $port, DOMElement $binding)
    {
        $args = [];
        $annotations = [];
        $sequence = [];
    Severity: Major
    Found in src/PHPClass2WSDL.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (is_array($input)) {
            $inputElement = $this->dom->createElement('input');
            $soapElement = $this->dom->createElement('soap:body');
            foreach ($input as $name => $value) {
                $soapElement->setAttribute($name, $value);
      Severity: Major
      Found in src/WSDL.php and 1 other location - About 2 hrs to fix
      src/WSDL.php on lines 259..276

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (is_array($output)) {
            $outputElement = $this->dom->createElement('output');
            $soapElement = $this->dom->createElement('soap:body');
            foreach ($output as $name => $value) {
                $soapElement->setAttribute($name, $value);
      Severity: Major
      Found in src/WSDL.php and 1 other location - About 2 hrs to fix
      src/WSDL.php on lines 240..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      WSDL has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class WSDL
{

    /**
     * The DOMDocument instance.
      Severity: Minor
      Found in src/WSDL.php - About 2 hrs to fix

        Function addBindingOperation has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addBindingOperation(DOMElement $binding,
                                        $name,
                                        array $input = null,
                                        array $output = null,
                                        array $inputHeaders = null,
        Severity: Minor
        Found in src/WSDL.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parseElement has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private function parseElement(array $element)
    {
        $elementXml = $this->dom->createElement('xsd:element');
        foreach ($element as $key => $value) {
            if (in_array($key, ['sequence', 'all', 'choice'])) {
        Severity: Minor
        Found in src/WSDL.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addComplexType has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function addComplexType($type)
    {
        if (isset($this->includedTypes[$type])) {
            return $this->includedTypes[$type];
        }
        Severity: Minor
        Found in src/WSDL.php - About 1 hr to fix

          Method addBindingOperation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function addBindingOperation(DOMElement $binding,
                                        $name,
                                        array $input = null,
                                        array $output = null,
                                        array $inputHeaders = null,
          Severity: Minor
          Found in src/WSDL.php - About 1 hr to fix

            Function getXSDType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getXSDType($type)
    {
        if ($this->isXDSType($type)) {
            return self::$XSDTypes[strtolower($type)];
        } elseif ($type) {
            Severity: Minor
            Found in src/WSDL.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method addBindingOperation has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function addBindingOperation(DOMElement $binding,
                                        $name,
                                        array $input = null,
                                        array $output = null,
                                        array $inputHeaders = null,
            Severity: Minor
            Found in src/WSDL.php - About 45 mins to fix

              Function addMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function addMessage($name, array $parts)
    {
        $message = $this->dom->createElement('message');
        $message->setAttribute('name', $name);
              Severity: Minor
              Found in src/WSDL.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function generateWSDLClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function generateWSDLClass($class)
    {
        $ref = new ReflectionClass($class);
        $docs = $ref->getReflectionDocComment()->getAnnotationsCollection();
        if ($docs->hasAnnotationTag('soap')) {
              Severity: Minor
              Found in src/PHPClass2WSDL.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language