Sign upLogin

SeunAdelekan/Kanary

View on GitHub
Star
examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt

Summary

Maintainability
F
3 days
Test Coverage

Method fetchUserFeed has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    fun fetchUserFeed(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
Severity: Major
Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 2 hrs to fix

    Method fetchFeed has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        fun fetchFeed(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
    Severity: Minor
    Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 1 hr to fix

      Method createCweet has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fun createCweet(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
      Severity: Minor
      Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 1 hr to fix

        Method fetchUserFeed has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
        Open

            fun fetchUserFeed(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
        Severity: Minor
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                (0..cweets.size-1).forEach { i ->
            val cweetNode = mapper.createObjectNode()
            with(cweetNode){
                put("cweet_id", cweets[i].cweetId)
                put("user_id", cweets[i].creatorId)
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 4 hrs to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 197..208

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 292.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    (0..cweets.size-1).forEach { i ->
                val cweetNode = mapper.createObjectNode()
                with(cweetNode){
                    put("cweet_id", cweets[i].cweetId)
                    put("user_id", cweets[i].creatorId)
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 4 hrs to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 117..128

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 292.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                with(userNode) {
            put("user_id", user?.id)
            put("first_name", user?.firstName)
            put("last_name", user?.lastName)
            put("email", user?.email)
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 1 hr to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 175..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 124.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    with(currentUserNode) {
                put("user_id", user?.id)
                put("first_name", user?.firstName)
                put("last_name", user?.lastName)
                put("email", user?.email)
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 1 hr to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 132..137

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 124.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                if (user == null){
            with(responseRootNode) {
                put("status", "error")
                put("message", "unauthorized access")
            }
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 2 other locations - About 1 hr to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 58..66
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 155..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                if (user == null){
            with(responseRootNode) {
                put("status", "error")
                put("message", "unauthorized access")
            }
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 2 other locations - About 1 hr to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 102..110
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 155..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                if (user == null){
            with(responseRootNode) {
                put("status", "error")
                put("message", "unauthorized access")
            }
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 2 other locations - About 1 hr to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 58..66
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 102..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            fun opt(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        response withStatus 200 send "F*ck you CORS!!"
        baseRequest.done()
    }
        Severity: Minor
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 40 mins to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 27..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                } else {
            with(responseRootNode) {
                put("status", "error")
                put("message", "incomplete or invalid details provided")
            }
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 6 other locations - About 40 mins to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 67..72
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 73..78
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 79..84
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 123..128
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 129..134
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 225..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                } else {
            with(responseRootNode) {
                put("status", "error")
                put("message", "user id not found in request")
            }
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 6 other locations - About 40 mins to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 67..72
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 73..78
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 79..84
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 123..128
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt on lines 129..134
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 87..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status