Sign upLogin

SeunAdelekan/Kanary

View on GitHub
Star
src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt

Summary

Maintainability
C
1 day
Test Coverage

Method addRoute has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

    /**
     * Invoked to register a new route to the router.
     *
     * @param routeType - type of route to be added. See [RouteType].
     * @param path - URL path.
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addRoute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /**
     * Invoked to register a new route to the router.
     *
     * @param routeType - type of route to be added. See [RouteType].
     * @param path - URL path.
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 1 hr to fix

    Method getRouteNode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        /**
     * Invoked to resolve a corresponding RouteNode to a given URL target - if any.
     *
     * @param path - URL path (target).
     * @return [RouteNode] - Returns corresponding instance of [RouteNode], if one exists. Else returns null.
    Severity: Minor
    Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if (i == subPaths.size - 1) {
                            childNode.action = action
                        }
      Severity: Major
      Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (middleware != null) {
                            childNode.addMiddleware(middleware)
                        }
        Severity: Major
        Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 45 mins to fix

          Method getRouteNode has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
          Open

              /**
     * Invoked to resolve a corresponding RouteNode to a given URL target - if any.
     *
     * @param path - URL path (target).
     * @return [RouteNode] - Returns corresponding instance of [RouteNode], if one exists. Else returns null.
          Severity: Minor
          Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      currentNode.getChildren().forEach {
                if (it.path == currentSegment || it.path[0] == ':') {
                    queue.add(it)
                }
            }
          Severity: Minor
          Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt and 1 other location - About 55 mins to fix
          src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt on lines 96..100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  getRouteList(method).forEach {
            if (it.path == currentSegment || it.path[0] == ':') {
                queue.add(it)
            }
        }
          Severity: Minor
          Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt and 1 other location - About 55 mins to fix
          src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt on lines 112..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status