Sign upLogin

SeunAdelekan/Kanary

View on GitHub
Star
src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt

Summary

Maintainability
D
2 days
Test Coverage

Method resolveTargetRoute has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

    /**
     * Method used for route resolution
     * @param method HTTP method of the request
     * @param target Target resource
     * @return route required to handle HTTP request
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolveTargetRoute has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /**
     * Method used for route resolution
     * @param method HTTP method of the request
     * @param target Target resource
     * @return route required to handle HTTP request
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt - About 1 hr to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.PUT.name -> {
                    matchedRoutes = router.putRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 89..94
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 95..100
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 107..112
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 113..118
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.PATCH.name -> {
                    matchedRoutes = router.patchRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 89..94
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 95..100
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 101..106
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 107..112
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.GET.name -> {
                    matchedRoutes = router.getRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 95..100
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 101..106
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 107..112
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 113..118
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.DELETE.name -> {
                    matchedRoutes = router.deleteRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 89..94
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 95..100
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 101..106
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 113..118
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.POST.name -> {
                    matchedRoutes = router.postRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 89..94
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 101..106
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 107..112
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 113..118
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

                    HttpConstants.OPTIONS.name -> {
                    matchedRoutes = router.optionsRouteList.filter { it.path == formattedTarget }
                    if(matchedRoutes.isNotEmpty()) {
                        route = matchedRoutes[0]
                    }
    Severity: Major
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 5 other locations - About 1 hr to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 89..94
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 95..100
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 101..106
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 107..112
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 113..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        /**
     * Calls beforeAction life cycle callback of route's Associated controller
     * @param route Instance of [Route]
     * @param request Instance of [HttpServletRequest]
     * @param response Instance of [HttpServletResponse]
    Severity: Minor
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 1 other location - About 45 mins to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 140..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        /**
     * Calls afterAction life cycle callback of route's Associated controller
     * @param route Instance of [Route]
     * @param request Instance of [HttpServletRequest]
     * @param response Instance of [HttpServletResponse]
    Severity: Minor
    Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt and 1 other location - About 45 mins to fix
    src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt on lines 130..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status