Sign upLogin

Shoobx/pjpersist

View on GitHub
Star

Showing 89 of 89 total issues

Function __setitem__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def __setitem__(self, key, value):
        # When the key is None, we need to determine it.
        orig_key = key
        if key is None:
            if self._pj_mapping_key is None:
Severity: Minor
Found in src/pjpersist/zope/container.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if objectType == datetime.datetime:
            return {'_py_type': 'datetime.datetime',
                    'value': obj.strftime(FMT_DATETIME).zfill(FMT_DATETIME_LENGTH)}
Severity: Minor
Found in src/pjpersist/serialize.py and 1 other location - About 35 mins to fix
src/pjpersist/serialize.py on lines 350..352

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if objectType == datetime.date:
            return {'_py_type': 'datetime.date',
                    'value': obj.strftime(FMT_DATE).zfill(FMT_DATE_LENGTH)}
Severity: Minor
Found in src/pjpersist/serialize.py and 1 other location - About 35 mins to fix
src/pjpersist/serialize.py on lines 356..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get_non_persistent_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get_non_persistent_object(self, state, obj):
        if '_py_constant' in state:
            return self.simple_resolve(state['_py_constant'])

        # this method must NOT change the passed in state dict
Severity: Minor
Found in src/pjpersist/serialize.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function remove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def remove(self, obj):
        if obj._p_oid is None:
            raise ValueError('Object._p_oid is None.', obj)
        # If the object is still in the ghost state, let's load it, so that we
        # have the state in case we abort the transaction later.
Severity: Minor
Found in src/pjpersist/datamanager.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return sb.RLIKE(sb.TEXT(op1), op2)
Severity: Major
Found in src/pjpersist/mquery.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return [self.get_state(value, pobj) for value in obj]
    Severity: Major
    Found in src/pjpersist/serialize.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return sb.JSONB_CONTAINS_ANY(op1, op2)
      Severity: Major
      Found in src/pjpersist/mquery.py - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            def can_read(self, state):
        return isinstance(state, dict) and \
               state.get('_py_type') == 'datetime.time'
        Severity: Minor
        Found in src/pjpersist/serializers.py and 2 other locations - About 30 mins to fix
        src/pjpersist/serializers.py on lines 24..26
        src/pjpersist/serializers.py on lines 64..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            def can_read(self, state):
        return isinstance(state, dict) and \
               state.get('_py_type') == 'datetime.datetime'
        Severity: Minor
        Found in src/pjpersist/serializers.py and 2 other locations - About 30 mins to fix
        src/pjpersist/serializers.py on lines 24..26
        src/pjpersist/serializers.py on lines 43..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                    return sb.OR(*ops)
        Severity: Major
        Found in src/pjpersist/mquery.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return datetime.datetime.strptime(
          Severity: Major
          Found in src/pjpersist/serialize.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return {'_py_type': 'datetime.time',
            Severity: Major
            Found in src/pjpersist/serialize.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                  return datetime.datetime.strptime(
              Severity: Major
              Found in src/pjpersist/serialize.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return sb.STARTSWITH(sb.TEXT(op1), op2)
                Severity: Major
                Found in src/pjpersist/mquery.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return {'_py_type': 'datetime.datetime',
                  Severity: Major
                  Found in src/pjpersist/serialize.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return self.get_non_persistent_object(state, obj)
                    Severity: Major
                    Found in src/pjpersist/serialize.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return True
                      Severity: Major
                      Found in src/pjpersist/mquery.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return sb.func.jsonb_array_length(op1) == op2
                        Severity: Major
                        Found in src/pjpersist/mquery.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return {'_py_type': 'type',
                          Severity: Major
                          Found in src/pjpersist/serialize.py - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language