Sign upLogin

Sibyx/phpGPX

View on GitHub
Star

Showing 343 of 345 total issues

Method parse has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function parse(\SimpleXMLElement $nodes)
    {
        $tracks = [];

        foreach ($nodes as $node) {
Severity: Minor
Found in src/phpGPX/Parsers/TrackParser.php - About 1 hr to fix

    Avoid using undefined variables such as '$usedNamespaces' which will lead to PHP notices.
    Open

            ExtensionParser::$usedNamespaces[TrackPointExtension::EXTENSION_NAME] = [
    Severity: Minor
    Found in src/phpGPX/Parsers/Extensions/TrackPointExtensionParser.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Method toXML has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function toXML(Track $track, \DOMDocument &$document)
    {
        $node = $document->createElement(self::$tagName);

        foreach (self::$attributeMapper as $key => $attribute) {
    Severity: Minor
    Found in src/phpGPX/Parsers/TrackParser.php - About 1 hr to fix

      Method toXML has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function toXML(Route $route, \DOMDocument &$document)
    {
        $node = $document->createElement(self::$tagName);

        foreach (self::$attributeMapper as $key => $attribute) {
      Severity: Minor
      Found in src/phpGPX/Parsers/RouteParser.php - About 1 hr to fix

        Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function parse(\SimpleXMLElement $node)
    {
        if (!array_key_exists($node->getName(), self::$typeMapper)) {
            return null;
        }
        Severity: Minor
        Found in src/phpGPX/Parsers/PointParser.php - About 1 hr to fix

          Function calculate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function calculate($strategy)
    {
        $distance = 0;

        $pointCount = count($this->points);
          Severity: Minor
          Found in src/phpGPX/Helpers/DistanceCalculator.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isset($firstPoint->time) && isset($lastPoint->time) && $firstPoint->time instanceof \DateTime && $lastPoint->time instanceof \DateTime) {
            $this->stats->duration = $lastPoint->time->getTimestamp() - $firstPoint->time->getTimestamp();

            if ($this->stats->duration != 0) {
                $this->stats->averageSpeed = $this->stats->distance / $this->stats->duration;
          Severity: Major
          Found in src/phpGPX/Models/Segment.php and 1 other location - About 1 hr to fix
          src/phpGPX/Models/Route.php on lines 130..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (($firstPoint->time instanceof \DateTime) && ($lastPoint->time instanceof \DateTime)) {
            $this->stats->duration = $lastPoint->time->getTimestamp() - $firstPoint->time->getTimestamp();

            if ($this->stats->duration != 0) {
                $this->stats->averageSpeed = $this->stats->distance / $this->stats->duration;
          Severity: Major
          Found in src/phpGPX/Models/Route.php and 1 other location - About 1 hr to fix
          src/phpGPX/Models/Segment.php on lines 120..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function calculate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function calculate(array $points): array
    {
        $pointCount = count($points);

        $north = $east = -PHP_FLOAT_MAX; // look for longest lat and lon
          Severity: Minor
          Found in src/phpGPX/Helpers/BoundsCalculator.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function parse($node)
    {
        $extension = new TrackPointExtension();

        foreach (self::$attributeMapper as $key => $attribute) {
          Severity: Minor
          Found in src/phpGPX/Parsers/Extensions/TrackPointExtensionParser.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $hr. Configured minimum length is 3.
          Open

              public $hr;
          Severity: Minor
          Found in src/phpGPX/Models/Extensions/TrackPointExtension.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $nw. Configured minimum length is 3.
          Open

                  $nw = $this->testModelInstance->stats->bounds[0];
          Severity: Minor
          Found in tests/UnitTests/phpGPX/Parsers/SegmentParserTest.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $a. Configured minimum length is 3.
          Open

                  $a = pow(cos($latTo) * sin($lonDelta), 2) + pow(cos($latFrom) * sin($latTo) - sin($latFrom) * cos($latTo) * cos($lonDelta), 2);
          Severity: Minor
          Found in src/phpGPX/Helpers/GeoHelper.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $se. Configured minimum length is 3.
          Open

                  $se = $this->testModelInstance->stats->bounds[1];
          Severity: Minor
          Found in tests/UnitTests/phpGPX/Parsers/SegmentParserTest.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $b. Configured minimum length is 3.
          Open

                  $b = sin($latFrom) * sin($latTo) + cos($latFrom) * cos($latTo) * cos($lonDelta);
          Severity: Minor
          Found in src/phpGPX/Helpers/GeoHelper.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          The property $SORT_BY_TIMESTAMP is not named in camelCase.
          Open

          class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
          Severity: Minor
          Found in src/phpGPX/phpGPX.php by phpmd

          CamelCasePropertyName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name attributes.

          Example

          class ClassName {
    protected $property_name;
}

          Source

          The property $APPLY_DISTANCE_SMOOTHING is not named in camelCase.
          Open

          class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
          Severity: Minor
          Found in src/phpGPX/phpGPX.php by phpmd

          CamelCasePropertyName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name attributes.

          Example

          class ClassName {
    protected $property_name;
}

          Source

          The class phpGPX is not named in CamelCase.
          Open

          class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
          Severity: Minor
          Found in src/phpGPX/phpGPX.php by phpmd

          CamelCaseClassName

          Since: 0.2

          It is considered best practice to use the CamelCase notation to name classes.

          Example

          class class_name {
}

          Source

          The property $DATETIME_TIMEZONE_OUTPUT is not named in camelCase.
          Open

          class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
          Severity: Minor
          Found in src/phpGPX/phpGPX.php by phpmd

          CamelCasePropertyName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name attributes.

          Example

          class ClassName {
    protected $property_name;
}

          Source

          The property $ELEVATION_SMOOTHING_SPIKES_THRESHOLD is not named in camelCase.
          Open

          class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
          Severity: Minor
          Found in src/phpGPX/phpGPX.php by phpmd

          CamelCasePropertyName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name attributes.

          Example

          class ClassName {
    protected $property_name;
}

          Source

          Severity
          Category
          Status
          Source
          Language