Sign upLogin

Sibyx/phpGPX

View on GitHub
Star

Showing 343 of 345 total issues

The property $DISTANCE_SMOOTHING_THRESHOLD is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $wp. Configured minimum length is 3.
Open

        $wp = [];
Severity: Minor
Found in tests/CreateWaypointTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $IGNORE_ELEVATION_0 is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $CALCULATE_STATS is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $APPLY_ELEVATION_SMOOTHING is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $ELEVATION_SMOOTHING_THRESHOLD is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public $id;
Severity: Minor
Found in src/phpGPX/Models/Email.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $PRETTY_PRINT is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $DATETIME_FORMAT is not named in camelCase.
Open

class phpGPX
{
    const JSON_FORMAT = 'json';
    const XML_FORMAT = 'xml';
Severity: Minor
Found in src/phpGPX/phpGPX.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class GpxFile has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
Open

class GpxFile implements Summarizable
{
    /**
     * A list of waypoints.
     * @var Point[]
Severity: Minor
Found in src/phpGPX/Models/GpxFile.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Function toXML has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function toXML()
    {
        $document = new \DOMDocument("1.0", 'UTF-8');

        $gpx = $document->createElementNS("http://www.topografix.com/GPX/1/1", "gpx");
Severity: Minor
Found in src/phpGPX/Models/GpxFile.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static function parse($nodes)
    {
        $extensions = new Extensions();

        $nodeNamespaces = $nodes->getNamespaces(true);
Severity: Minor
Found in src/phpGPX/Parsers/ExtensionParser.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '42', column '31').
Open

            $datetime->setTimezone(new \DateTimeZone($timezone));
Severity: Minor
Found in src/phpGPX/Helpers/DateTimeHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '21').
Open

        $reflection = new \ReflectionClass($this->testParserClass);
Severity: Minor
Found in tests/UnitTests/phpGPX/Parsers/AbstractParserTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '181', column '15').
Open

                throw new \RuntimeException("Unsupported file format!");
Severity: Minor
Found in src/phpGPX/Models/GpxFile.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '66', column '19').
Open

        $document = new \DOMDocument("1.0", 'UTF-8');
Severity: Minor
Found in tests/UnitTests/phpGPX/Parsers/ExtensionParserTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '18', column '16').
Open

        $time1 = new \DateTime("2017-08-12T20:16:29+00:00", new \DateTimeZone("UTC"));
Severity: Minor
Found in tests/UnitTests/phpGPX/Helpers/DateTimeHelperTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '18', column '59').
Open

        $time1 = new \DateTime("2017-08-12T20:16:29+00:00", new \DateTimeZone("UTC"));
Severity: Minor
Found in tests/UnitTests/phpGPX/Helpers/DateTimeHelperTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '70', column '21').
Open

        $reflection = new \ReflectionClass($this->testParserClass);
Severity: Minor
Found in tests/UnitTests/phpGPX/Parsers/AbstractParserTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '56', column '19').
Open

        $timezone = new \DateTimeZone($timezone);
Severity: Minor
Found in src/phpGPX/Helpers/DateTimeHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language