Similar blocks of code found in 3 locations. Consider refactoring. Open
beforeEach(() => {
fixture = TestBed.createComponent(DonateComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 48.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
space indentation expected Open
snapshot: { data: {} }
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
space indentation expected Open
providers: [ Web3Service,
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
space indentation expected Open
const fakeActivatedRoute = {
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
trailing whitespace Open
import { FormsModule } from '@angular/forms';
- Read upRead up
- Exclude checks
Rule: no-trailing-whitespace
Disallows trailing whitespace at the end of a line.
Rationale
Keeps version control diffs clean as it prevents accidental whitespace from being committed.
Notes
- Has Fix
Config
Possible settings are:
-
"ignore-template-strings"
: Allows trailing whitespace in template strings. -
"ignore-comments"
: Allows trailing whitespace in comments. -
"ignore-jsdoc"
: Allows trailing whitespace only in JSDoc comments. -
"ignore-blank-lines"
: Allows trailing whitespace on empty lines.
Examples
"no-trailing-whitespace": true
"no-trailing-whitespace": true,ignore-comments
"no-trailing-whitespace": true,ignore-jsdoc
Schema
{
"type": "array",
"items": {
"type": "string",
"enum": [
"ignore-comments",
"ignore-jsdoc",
"ignore-template-strings",
"ignore-blank-lines"
]
}
}
For more information see this page.
space indentation expected Open
} as ActivatedRoute;
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
space indentation expected Open
imports: [ FormsModule, HttpClientTestingModule ],
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
space indentation expected Open
declarations: [ DonateComponent ],
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.
space indentation expected Open
{ provide: ActivatedRoute, useValue: fakeActivatedRoute } ]
- Read upRead up
- Exclude checks
Rule: indent
Enforces indentation with tabs or spaces.
Rationale
Using only one of tabs or spaces for indentation leads to more consistent editor behavior, cleaner diffs in version control, and easier programmatic manipulation.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
spaces
enforces consistent spaces. -
tabs
enforces consistent tabs.
A second optional argument specifies indentation size:
-
2
enforces 2 space indentation. -
4
enforces 4 space indentation.
Indentation size is required for auto-fixing, but not for rule checking.
NOTE: auto-fixing will only convert invalid indent whitespace to the desired type, it will not fix invalid whitespace sizes.
Examples
"indent": true,spaces
"indent": true,spaces,4
"indent": true,tabs,2
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"tabs",
"spaces"
]
},
{
"type": "number",
"enum": [
2,
4
]
}
],
"minLength": 0,
"maxLength": 5
}
For more information see this page.