SimenB/stylint

View on GitHub

Showing 133 of 133 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        it( 'undefined if line has no comment', function() {
            app.state.hasComment = false
            assert.equal( undefined, commentSpaceTest( '', '.test' ) )
        } )
Severity: Minor
Found in test/test.js and 1 other location - About 30 mins to fix
test/test.js on lines 831..834

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        it( 'undefined if from or to used outside keyframes', function() {
            assert.equal( undefined, validTest( 'from 0%' ) )
            assert.equal( undefined, validTest( 'to 100%' ) )
        } )
Severity: Major
Found in test/test.js and 8 other locations - About 30 mins to fix
test/test.js on lines 536..539
test/test.js on lines 759..762
test/test.js on lines 1668..1671
test/test.js on lines 2331..2334
test/test.js on lines 2336..2339
test/test.js on lines 2384..2387
test/test.js on lines 2389..2392
test/test.js on lines 2414..2417

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        it( 'true if whitespace found', function() {
            assert.ok( whitespaceTest( '', 'margin 0 auto    ' ) )
            assert.ok( whitespaceTest( '', 'margin 0 auto ' ) )
        } )
Severity: Minor
Found in test/test.js and 2 other locations - About 30 mins to fix
test/test.js on lines 774..777
test/test.js on lines 800..803

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        it( 'true if no space after commas', function() {
            assert.ok( commaTest( '', '0,0,0,.18' ) )
            assert.ok( commaTest( '', 'mixin( $param1,$param2 )' ) )
        } )
Severity: Minor
Found in test/test.js and 2 other locations - About 30 mins to fix
test/test.js on lines 774..777
test/test.js on lines 2172..2175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        it( 'false if line comment doesnt have a space after it', function() {
            app.cache.comment = '//test'
            assert.equal( false, commentSpaceTest( '', '' ) )
        } )
Severity: Minor
Found in test/test.js and 2 other locations - About 30 mins to fix
test/test.js on lines 845..848
test/test.js on lines 1401..1404

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        it( 'false if no mixed spaces and tabs found: tabs preferred', function() {
            app.config.indentPref = 'tabs'
            assert.equal( false, mixed( '', '    margin 0' ) )
        } )
Severity: Minor
Found in test/test.js and 2 other locations - About 30 mins to fix
test/test.js on lines 821..824
test/test.js on lines 845..848

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        it( 'undefined if no 0 on line', function() {
            assert.equal( undefined, zeroTest( 'margin auto' ) )
            assert.equal( undefined, zeroTest( 'padding 53px' ) )
        } )
Severity: Major
Found in test/test.js and 8 other locations - About 30 mins to fix
test/test.js on lines 536..539
test/test.js on lines 759..762
test/test.js on lines 1668..1671
test/test.js on lines 2270..2273
test/test.js on lines 2331..2334
test/test.js on lines 2336..2339
test/test.js on lines 2389..2392
test/test.js on lines 2414..2417

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        it( 'undefined if relative value', function() {
            assert.equal( undefined, zeroTest( 'line-height 1' ) )
            assert.equal( undefined, zeroTest( 'font-weight 600' ) )
        } )
Severity: Major
Found in test/test.js and 8 other locations - About 30 mins to fix
test/test.js on lines 536..539
test/test.js on lines 759..762
test/test.js on lines 1668..1671
test/test.js on lines 2270..2273
test/test.js on lines 2331..2334
test/test.js on lines 2384..2387
test/test.js on lines 2389..2392
test/test.js on lines 2414..2417

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return
Severity: Major
Found in src/core/setState.js - About 30 mins to fix

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            it( 'undefined if relative value', function() {
                assert.equal( undefined, zeroTest( 'line-height 1' ) )
                assert.equal( undefined, zeroTest( 'font-weight 600' ) )
            } )
    Severity: Major
    Found in test/test.js and 8 other locations - About 30 mins to fix
    test/test.js on lines 536..539
    test/test.js on lines 759..762
    test/test.js on lines 1668..1671
    test/test.js on lines 2270..2273
    test/test.js on lines 2331..2334
    test/test.js on lines 2336..2339
    test/test.js on lines 2384..2387
    test/test.js on lines 2414..2417

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    var init = function( options, pathPassed ) {
        options = defaults( options || {}, defaultOptions )
    
        this.config = this.setConfig( options.config )
    
    
    Severity: Minor
    Found in src/core/init.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function extendPref has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    var extendPref = function( line ) {
        if ( line.indexOf( '@extend' ) === -1 ) { return }
    
        var extendIncorrect = false
    
    
    Severity: Minor
    Found in src/checks/extendPref.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function commentSpace has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    var commentSpace = function( line, origLine ) {
        if ( !this.state.hasComment ) { return }
    
        var spaceAfterComment = false
        var comment = this.cache.comment
    Severity: Minor
    Found in src/checks/commentSpace.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language