Sign upLogin

SimonBaeumer/goss

View on GitHub
Star

Showing 157 of 157 total issues

Function ValidateValue has 80 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ValidateValue(res ResourceRead, property string, expectedValue interface{}, actual interface{}, skip bool) TestResult {
    format.TruncatedDiff = false
    id := res.ID()
    title := res.GetTitle()
    meta := res.GetMeta()
Severity: Major
Found in resource/validate.go - About 2 hrs to fix

    Method Add.AddResource has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func (a *Add) AddResource(fileName string, gossConfig GossConfig, resourceName, key string, config util.Config) error {
        // Need to figure out a good way to refactor this
        switch resourceName {
        case "addr":
            res, err := gossConfig.Addrs.AppendSysResource(key, a.Sys, config)
    Severity: Minor
    Found in add.go - About 2 hrs to fix

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r ResourceTypeMap) AppendSysResourceIfExists(sr string, sys *system.System) (*ResourceType, system.ResourceType, bool) {
        sysres := sys.NewResourceType(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewResourceType(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list_genny.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r UserMap) AppendSysResourceIfExists(sr string, sys *system.System) (*User, system.User, bool) {
        sysres := sys.NewUser(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewUser(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r DNSMap) AppendSysResourceIfExists(sr string, sys *system.System) (*DNS, system.DNS, bool) {
        sysres := sys.NewDNS(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewDNS(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r KernelParamMap) AppendSysResourceIfExists(sr string, sys *system.System) (*KernelParam, system.KernelParam, bool) {
        sysres := sys.NewKernelParam(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewKernelParam(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r GossfileMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Gossfile, system.Gossfile, bool) {
        sysres := sys.NewGossfile(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewGossfile(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r PortMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Port, system.Port, bool) {
        sysres := sys.NewPort(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewPort(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r ServiceMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Service, system.Service, bool) {
        sysres := sys.NewService(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewService(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r HTTPMap) AppendSysResourceIfExists(sr string, sys *system.System) (*HTTP, system.HTTP, bool) {
        sysres := sys.NewHTTP(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewHTTP(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r InterfaceMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Interface, system.Interface, bool) {
        sysres := sys.NewInterface(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewInterface(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r ProcessMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Process, system.Process, bool) {
        sysres := sys.NewProcess(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewProcess(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r AddrMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Addr, system.Addr, bool) {
        sysres := sys.NewAddr(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewAddr(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r CommandMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Command, system.Command, bool) {
        sysres := sys.NewCommand(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewCommand(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r FileMap) AppendSysResourceIfExists(sr string, sys *system.System) (*File, system.File, bool) {
        sysres := sys.NewFile(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewFile(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r MountMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Mount, system.Mount, bool) {
        sysres := sys.NewMount(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewMount(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 538..551
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    func (r GroupMap) AppendSysResourceIfExists(sr string, sys *system.System) (*Group, system.Group, bool) {
        sysres := sys.NewGroup(sr, sys, util.Config{})
        // FIXME: Do we want to be silent about errors?
        res, _ := NewGroup(sysres, util.Config{})
        if e, _ := sysres.Exists(); e != true {
    Severity: Major
    Found in resource/resource_list.go and 14 other locations - About 2 hrs to fix
    resource/resource_list.go on lines 38..51
    resource/resource_list.go on lines 138..151
    resource/resource_list.go on lines 238..251
    resource/resource_list.go on lines 338..351
    resource/resource_list.go on lines 438..451
    resource/resource_list.go on lines 738..751
    resource/resource_list.go on lines 838..851
    resource/resource_list.go on lines 938..951
    resource/resource_list.go on lines 1038..1051
    resource/resource_list.go on lines 1138..1151
    resource/resource_list.go on lines 1238..1251
    resource/resource_list.go on lines 1338..1351
    resource/resource_list.go on lines 1452..1465
    resource/resource_list_genny.go on lines 38..51

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func LookupAAAA(host string, server string, c *dns.Client, m *dns.Msg) (addrs []string, err error) {
        m.SetQuestion(dns.Fqdn(host), dns.TypeAAAA)
        r, _, err := c.Exchange(m, net.JoinHostPort(server, "53"))
        if err != nil {
            return nil, err
    Severity: Major
    Found in system/dns.go and 1 other location - About 1 hr to fix
    system/dns.go on lines 194..208

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func LookupA(host string, server string, c *dns.Client, m *dns.Msg) (addrs []string, err error) {
        m.SetQuestion(dns.Fqdn(host), dns.TypeA)
        r, _, err := c.Exchange(m, net.JoinHostPort(server, "53"))
        if err != nil {
            return nil, err
    Severity: Major
    Found in system/dns.go and 1 other location - About 1 hr to fix
    system/dns.go on lines 211..225

    Function createValidateCommand has 70 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func createValidateCommand(app *cli.App) cli.Command {
        startTime := time.Now()
     
        return cli.Command{
            Name:    "validate",
    Severity: Minor
    Found in cmd/goss/goss.go - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language