Sign upLogin

SimonBaeumer/goss

View on GitHub
Star

Showing 157 of 157 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func LookupNS(host string, server string, c *dns.Client, m *dns.Msg) (addrs []string, err error) {
    m.SetQuestion(dns.Fqdn(host), dns.TypeNS)
    r, _, err := c.Exchange(m, net.JoinHostPort(server, "53"))
    if err != nil {
        return nil, err
Severity: Major
Found in system/dns.go and 2 other locations - About 1 hr to fix
system/dns.go on lines 228..242
system/dns.go on lines 301..315

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func LookupTXT(host string, server string, c *dns.Client, m *dns.Msg) (addrs []string, err error) {
    m.SetQuestion(dns.Fqdn(host), dns.TypeTXT)
    r, _, err := c.Exchange(m, net.JoinHostPort(server, "53"))
    if err != nil {
        return nil, err
Severity: Major
Found in system/dns.go and 2 other locations - About 1 hr to fix
system/dns.go on lines 228..242
system/dns.go on lines 263..277

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func LookupCNAME(host string, server string, c *dns.Client, m *dns.Msg) (addrs []string, err error) {
    m.SetQuestion(dns.Fqdn(host), dns.TypeCNAME)
    r, _, err := c.Exchange(m, net.JoinHostPort(server, "53"))
    if err != nil {
        return nil, err
Severity: Major
Found in system/dns.go and 2 other locations - About 1 hr to fix
system/dns.go on lines 263..277
system/dns.go on lines 301..315

Method Add.AutoAddResource has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func (a *Add) AutoAddResource(fileName string, gossConfig GossConfig, key string) error {
    // file
    if strings.Contains(key, "/") {
        if res, _, ok := gossConfig.Files.AppendSysResourceIfExists(key, a.Sys); ok == true {
            a.resourcePrint(fileName, res)
Severity: Minor
Found in add.go - About 1 hr to fix

Function matcherToGomegaMatcher has 18 return statements (exceeds 4 allowed).
Open

func matcherToGomegaMatcher(matcher interface{}) (types.GomegaMatcher, error) {
    switch x := matcher.(type) {
    case string, int, bool, float64:
        return gomega.Equal(x), nil
    case []interface{}:
Severity: Major
Found in resource/gomega.go - About 1 hr to fix

    Function createApp has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func createApp() *cli.App {
        app := cli.NewApp()
        app.EnableBashCompletion = true
        app.Version = version
        app.Name = "goss"
    Severity: Minor
    Found in cmd/goss/goss.go - About 1 hr to fix

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r GroupMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Group, error) {
          sysres := sys.NewGroup(sr, sys, config)
          res, err := NewGroup(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r ResourceTypeMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*ResourceType, error) {
          sysres := sys.NewResourceType(sr, sys, config)
          res, err := NewResourceType(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list_genny.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r DNSMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*DNS, error) {
          sysres := sys.NewDNS(sr, sys, config)
          res, err := NewDNS(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r ProcessMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Process, error) {
          sysres := sys.NewProcess(sr, sys, config)
          res, err := NewProcess(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r InterfaceMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Interface, error) {
          sysres := sys.NewInterface(sr, sys, config)
          res, err := NewInterface(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r PortMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Port, error) {
          sysres := sys.NewPort(sr, sys, config)
          res, err := NewPort(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r FileMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*File, error) {
          sysres := sys.NewFile(sr, sys, config)
          res, err := NewFile(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r AddrMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Addr, error) {
          sysres := sys.NewAddr(sr, sys, config)
          res, err := NewAddr(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r UserMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*User, error) {
          sysres := sys.NewUser(sr, sys, config)
          res, err := NewUser(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r MountMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Mount, error) {
          sysres := sys.NewMount(sr, sys, config)
          res, err := NewMount(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r GossfileMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Gossfile, error) {
          sysres := sys.NewGossfile(sr, sys, config)
          res, err := NewGossfile(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r ServiceMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Service, error) {
          sysres := sys.NewService(sr, sys, config)
          res, err := NewService(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r CommandMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*Command, error) {
          sysres := sys.NewCommand(sr, sys, config)
          res, err := NewCommand(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1124..1136
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      func (r KernelParamMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*KernelParam, error) {
          sysres := sys.NewKernelParam(sr, sys, config)
          res, err := NewKernelParam(sysres, config)
          if err != nil {
              return nil, err
      Severity: Major
      Found in resource/resource_list.go and 13 other locations - About 1 hr to fix
      resource/resource_list.go on lines 24..36
      resource/resource_list.go on lines 124..136
      resource/resource_list.go on lines 224..236
      resource/resource_list.go on lines 324..336
      resource/resource_list.go on lines 424..436
      resource/resource_list.go on lines 524..536
      resource/resource_list.go on lines 724..736
      resource/resource_list.go on lines 824..836
      resource/resource_list.go on lines 924..936
      resource/resource_list.go on lines 1024..1036
      resource/resource_list.go on lines 1224..1236
      resource/resource_list.go on lines 1324..1336
      resource/resource_list_genny.go on lines 24..36
      Severity
      Category
      Status
      Source
      Language