Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,375 of 1,375 total issues

Possibly zero references to use statement for classlike/namespace SearchCriteriaApplier (\Magento\Framework\Api\SearchCriteria\CollectionProcessorInterface)
Open

use Magento\Framework\Api\SearchCriteria\CollectionProcessorInterface as SearchCriteriaApplier;
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products/DataProvider/Product/CollectionProcessor/SearchCriteriaProcessor.php by phan

Doc-block of $resourceCollection in __construct is phpdoc param type \Magento\Framework\Data\Collection\AbstractDb which is not a permitted replacement of the nullable param type ?\Magento\Framework\Data\Collection\AbstractDb declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\Data\Collection\AbstractDb           $resourceCollection          Resource collection.
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer.php by phan

TODO found
Open

        // TODO: make sure destroying one instance of mouse doesn't mess with
Severity: Minor
Found in src/module-elasticsuite-catalog/view/frontend/web/js/mouse.js by fixme

XXX found
Open

     * @param string $filter The raw filter value (XXX-XXX)
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Layer/Filter/DataProvider/Decimal.php by fixme

Possibly zero references to use statement for classlike/namespace StoreInterface (\Magento\Store\Api\Data\StoreInterface)
Open

use Magento\Store\Api\Data\StoreInterface;
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Aggregations.php by phan

Argument 1 (args) is ?array but \Smile\ElasticsuiteCatalogGraphQl\Model\Resolver\Products::validateArgs() takes array defined at /code/src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products.php:95
Open

        $this->validateArgs($args);
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products.php by phan

TODO found
Open

 * @TODO Refactor/Mutualize all copy/pasted methods.
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Category/Fulltext/Collection.php by fixme

Saw a token Phan may have failed to parse after '* @return array()': after array, saw '('
Open

     * @return array()
Severity: Info
Found in src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Kpi.php by phan

Possibly zero references to use statement for classlike/namespace ObjectManager (\Magento\Framework\App\ObjectManager)
Open

use Magento\Framework\App\ObjectManager;
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Aggregations.php by phan

Possibly zero references to use statement for classlike/namespace CollectionFactory (\Smile\ElasticsuiteCatalogOptimizer\Model\ResourceModel\Optimizer\CollectionFactory)
Open

use Smile\ElasticsuiteCatalogOptimizer\Model\ResourceModel\Optimizer\CollectionFactory;
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/Provider/DefaultProvider.php by phan

TODO found
Open

     * @TODO: manage cache in this file for getSearchQueriesByChildren,
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Rule.php by fixme

Argument 5 (query) is null but \Smile\ElasticsuiteCore\Search\Request\Builder::create() takes \Smile\ElasticsuiteCore\Search\Request\QueryInterface|string defined at /code/src/module-elasticsuite-core/Search/Request/Builder.php:136
Open

        return $this->searchRequestBuilder->create($storeId, $this->containerName, 0, 0, null, [], [], $searchQuery, $aggregations);
Severity: Minor
Found in src/module-elasticsuite-analytics/Model/Report/SearchRequestBuilder.php by phan

Call to method getIsDisplayRelNofollow on non-class type null
Open

            $result[$attributeCode]['rel_nofollow'] = (bool) $attribute->getIsDisplayRelNofollow();
Severity: Critical
Found in src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php by phan

Possibly zero references to use statement for classlike/namespace Optimizer (\Smile\ElasticsuiteCatalogOptimizer\Model\Optimizer)
Open

use Smile\ElasticsuiteCatalogOptimizer\Model\Optimizer;
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/Provider/Exclude.php by phan

Returning type null but getOptimizer() is declared to return \Smile\ElasticsuiteCatalogOptimizer\Api\Data\OptimizerInterface
Open

        return null;
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Locator/RegistryLocator.php by phan

Assigning \Smile\ElasticsuiteCore\Search\Request\Query\Builder to property but \Smile\ElasticsuiteCatalogOptimizer\Model\Optimizer\Preview\CategoryQuery->queryBuilder is \Smile\ElasticsuiteCore\Search\Request\Query\Filter\QueryBuilder
Open

        $this->queryBuilder           = $queryBuilder;
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Preview/CategoryQuery.php by phan

Returning type \Smile\ElasticsuiteCatalogOptimizer\Api\Data\OptimizerInterface but deleteById() is declared to return bool
Open

        return $this->delete($this->getById($optimizerId));
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/OptimizerRepository.php by phan

Class \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection was passed to foreach, but it does not extend Traversable and none of its declared properties are accessible from this context. (This check excludes dynamic properties)
Open

            foreach ($this->productCollection as $product) {
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Autocomplete/Product/DataProvider.php by phan

Suspicious array access to float|int
Open

            $fields[$fieldName] = $this->mappingFieldFactory->create(['name' => $fieldName] + $fieldConfig);
Severity: Minor
Found in src/module-elasticsuite-core/Index/Indices/Config.php by phan

syntax error, unexpected 'private' (T_PRIVATE), expecting variable (T_VARIABLE)
Open

        private ClientInterface $client,
Severity: Critical
Found in src/module-elasticsuite-core/Index/Ingest/PipelineManager.php by phan
Severity
Category
Status
Source
Language