Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,375 of 1,375 total issues

Assigning string to property but \Smile\ElasticsuiteCore\Search\Request->spellingType is int
Open

            $this->spellingType = $spellingType;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request.php by phan

Doc-block of $filter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $filter       Bucket filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/TopHits.php by phan

Assigning ?\Magento\Framework\Search\Request\QueryInterface to property but \Smile\ElasticsuiteCore\Search\Request\Query\Filtered->filter is \Smile\ElasticsuiteCore\Search\Request\QueryInterface
Open

        $this->filter = $filter;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Filtered.php by phan

Argument 2 (productIds) is ?array|?array{} but \Smile\ElasticsuiteCatalog\Model\Product\Indexer\Fulltext\Action\Full::getSearchableProducts() takes string defined at /code/src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Action/Full.php:83
Open

            $products = $this->getSearchableProducts($storeId, $productIds, $productId);
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Action/Full.php by phan

Returning type \Smile\ElasticsuiteCatalog\Model\ResourceModel\Category\Fulltext\Collection but setSearchQuery() is declared to return \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection
Open

        return $this;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Category/Fulltext/Collection.php by phan

Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getFilterField() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:338
Open

            $fields = array_unique([$subject->getAttributeCode(), $this->attributeHelper->getFilterField($subject)]);
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php by phan

Possibly zero references to use statement for classlike/namespace ObjectManagerInterface (\Magento\Framework\ObjectManagerInterface)
Open

use Magento\Framework\ObjectManagerInterface;
Severity: Minor
Found in src/module-elasticsuite-core/Index/DataSourceResolver.php by phan

Possibly zero references to use statement for classlike/namespace TypeFactory (\Smile\ElasticsuiteCore\Api\Index\TypeInterfaceFactory)
Open

use Smile\ElasticsuiteCore\Api\Index\TypeInterfaceFactory as TypeFactory;
Severity: Minor
Found in src/module-elasticsuite-core/Index/Indices/Config.php by phan

Argument 1 (element) is \Magento\Config\Model\Config\Structure\Element\Section|\Smile\ElasticsuiteCore\Model\Search\Request\RelevanceConfig\Structure\Element\Section but \Smile\ElasticsuiteCore\Model\Search\Request\RelevanceConfig\Structure\Element\Section\Visibility::isVisible() takes \Magento\Config\Model\Config\Structure\AbstractElement defined at /code/src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig/Structure/Element/Section/Visibility.php:33
Open

        return $this->visibility->isVisible($this, $this->_scope);
Severity: Minor
Found in src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig/Structure/Element/Section.php by phan

Doc-block of $filter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $filter           Bucket filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/DateHistogram.php by phan

Doc-block of $filter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $filter       Bucket filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/QueryGroup.php by phan

Doc-block of $nestedFilter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $nestedFilter Nested filter for the bucket.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/Term.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Boolean should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Boolean.php by phan

Returning type null but getSearchQuery() is declared to return \Smile\ElasticsuiteCore\Search\Request\QueryInterface
Open

        return $query;
Severity: Minor
Found in src/module-elasticsuite-catalog-rule/Model/Rule.php by phan

Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
Open

            return trim($this->urlBuilder->getDirectUrl($urlPath), '/') . $this->categoryUrlSuffix;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Autocomplete/Category/ItemFactory.php by phan

Call to deprecated function \Smile\ElasticsuiteCatalog\Model\Product\Indexer\Fulltext\Datasource\InventoryData::getResourceModel() defined at /code/src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/InventoryData.php:88
Open

        $inventoryData = $this->getResourceModel()->loadInventoryData($storeId, array_keys($indexData));
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/InventoryData.php by phan

Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getMappingFieldOptions() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:123
Open

        return $this->attributeHelper->getMappingFieldOptions($attribute);
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php by phan

Possibly zero references to use statement for classlike/namespace CategoryInterface (\Magento\Catalog\Api\Data\CategoryInterface)
Open

use Magento\Catalog\Api\Data\CategoryInterface;
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Layer/CategoryPlugin.php by phan

Possibly zero references to use statement for classlike/namespace ContainerConfigurationFactory (\Smile\ElasticsuiteCore\Search\Request\ContainerConfigurationFactory)
Open

use Smile\ElasticsuiteCore\Search\Request\ContainerConfigurationFactory;
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes.php by phan

Possibly zero references to use statement for classlike/namespace Category (\Magento\Catalog\Model\Category)
Open

use Magento\Catalog\Model\Category;
Severity: Minor
Found in src/module-elasticsuite-catalog/Setup/UpgradeData.php by phan
Severity
Category
Status
Source
Language