Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,300 of 1,300 total issues

Possibly zero references to use statement for classlike/namespace CategoryInterface (\Magento\Catalog\Api\Data\CategoryInterface)
Open

use Magento\Catalog\Api\Data\CategoryInterface;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Layer/Filter/Category.php by phan

Assigning array<int></int> to property but \Smile\ElasticsuiteVirtualCategory\Model\Rule->instances is \Magento\Catalog\Model\Category[]
Open

            $this->instances[$rootCategoryId][$cacheKey] = $rootCategory;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Rule.php by phan

Argument 1 (controller) is \Magento\CatalogRule\Controller\Adminhtml\Promo\Widget\Chooser but \Smile\ElasticsuiteVirtualCategory\Plugin\Catalog\Category\ChooserPlugin::getIds() takes \Magento\Backend\App\Action defined at /code/src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/ChooserPlugin.php:100
Open

            $this->getIds($controller)
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/ChooserPlugin.php by phan

Returning type false|string but getProductSavedPositions() is declared to return array
Open

        return json_encode($productPositions, JSON_FORCE_OBJECT);
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/DataProviderPlugin.php by phan

Argument 1 (product) is \Magento\Catalog\Model\Product but \Smile\ElasticsuiteVirtualCategory\Model\Url::getProductRequestPath() takes \Smile\ElasticsuiteVirtualCategory\Model\Product defined at /code/src/module-elasticsuite-virtual-category/Model/Url.php:170
Open

            $requestPath = $this->urlModel->getProductRequestPath($product, $product->getCategory());
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/ProductPlugin.php by phan

Doc-block of $resource in __construct is phpdoc param type \Magento\Framework\Model\ResourceModel\Db\AbstractDb which is not a permitted replacement of the nullable param type ?\Magento\Framework\Model\ResourceModel\Db\AbstractDb declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\Model\ResourceModel\Db\AbstractDb         $resource       Abstract Resource
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

Doc-block of $resource in __construct is phpdoc param type \Magento\Framework\Model\ResourceModel\AbstractResource which is not a permitted replacement of the nullable param type ?\Magento\Framework\Model\ResourceModel\AbstractResource declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource           Magento Resource
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/Thesaurus.php by phan

Returning type false but getCurrentCategory() is declared to return \Magento\Catalog\Model\Category
Open

        return $category;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Category/Attribute/Source/VirtualCategoryRoot/CollectionFactory.php by phan

Suspicious array access to \Magento\Catalog\Model\Category
Open

        return $this->instances[$rootCategoryId][$cacheKey];
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Rule.php by phan

Call with 2 arg(s) to \Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\QueryBuilder::getSearchQuery() which only takes 1 arg(s) defined at /code/src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product/QueryBuilder.php:78
Open

        return $this->queryBuilder->getSearchQuery($categoryCondition, $excludedCategories);
Severity: Info
Found in src/module-elasticsuite-virtual-category/Model/Rule.php by phan

Returning type \Smile\ElasticsuiteVirtualCategory\Plugin\Catalog\Category\SaveProductsPositions but unserializeProductPositions() is declared to return array
Open

        return $this;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/SaveProductsPositions.php by phan

Returning type \Smile\ElasticsuiteCore\Api\Search\Request\Container\RelevanceConfigurationInterface but getConfig() is declared to return \Smile\ElasticsuiteThesaurus\Config\ThesaurusConfig
Open

        return $this->thesaurusConfigFactory->create($storeId, $containerName);
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/Index.php by phan

Doc-block of $entityFactory in __construct contains phpdoc param type \Magento\Framework\Data\Collection\EntityFactory which is incompatible with the param type \Magento\Framework\Data\Collection\EntityFactoryInterface declared in the signature
Open

     * @param \Magento\Framework\Data\Collection\EntityFactory             $entityFactory  Entity Factory
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

Assigning \Magento\Store\Model\StoreManagerInterface to property but \Smile\ElasticsuiteTracker\Helper\Data->storeManager is \Magento\Framework\App\Config\ScopeConfigInterface
Open

        $this->storeManager   = $storeManager;
Severity: Minor
Found in src/module-elasticsuite-tracker/Helper/Data.php by phan

Argument 5 (query) is null but \Smile\ElasticsuiteCore\Search\Request\Builder::create() takes \Smile\ElasticsuiteCore\Search\Request\QueryInterface|string defined at /code/src/module-elasticsuite-core/Search/Request/Builder.php:136
Open

        return $this->searchRequestBuilder->create($storeId, EventIndexInterface::INDEX_IDENTIFIER, 0, 0, null, [], [], $queryFilters);
Severity: Minor
Found in src/module-elasticsuite-tracker/Model/Data/Checker/Event/UndefinedSessionId.php by phan

Argument 5 (query) is null but \Smile\ElasticsuiteCore\Search\Request\Builder::create() takes \Smile\ElasticsuiteCore\Search\Request\QueryInterface|string defined at /code/src/module-elasticsuite-core/Search/Request/Builder.php:136
Open

        return $this->searchRequestBuilder->create($storeId, self::SEARCH_REQUEST_CONTAINER, 0, 0, null, [], [], $queryFilters);
Severity: Minor
Found in src/module-elasticsuite-tracker/Model/ResourceModel/SessionIndex.php by phan

Doc-block of getNotificationCode has declared return type string which is not a permitted replacement of the nullable return type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @return string
Severity: Minor
Found in src/module-elasticsuite-tracker/Model/Viewer/Log.php by phan

Doc-block of $category in getVirtualRule contains phpdoc param type \Smile\ElasticsuiteVirtualCategory\Block\Adminhtml\Catalog\Category\CategoryInterface which is incompatible with the param type \Magento\Catalog\Api\Data\CategoryInterface declared in the signature
Open

     * @param CategoryInterface $category Category
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Block/Adminhtml/Catalog/Category/VirtualRule.php by phan

Argument 2 (storeId) is int but \Smile\ElasticsuiteCore\Helper\Cache::cleanIndexCache() takes string defined at /code/src/module-elasticsuite-core/Helper/Cache.php:114
Open

        $this->cacheHelper->cleanIndexCache(ThesaurusIndex::INDEX_IDENTIER, $storeId);
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/Indexer/IndexHandler.php by phan

Class \Smile\ElasticsuiteThesaurus\Model\ResourceModel\Thesaurus\Collection was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)
Open

                foreach ($this as $item) {
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan
Severity
Category
Status
Source
Language