Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,357 of 1,357 total issues

Doc-block of $filter in __construct is phpdoc param type \Magento\Framework\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface       $filter         Search filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request.php by phan

Argument 1 (product) is \Magento\Catalog\Model\Product but \Smile\ElasticsuiteVirtualCategory\Model\Url::getProductRequestPath() takes \Smile\ElasticsuiteVirtualCategory\Model\Product defined at /code/src/module-elasticsuite-virtual-category/Model/Url.php:170
Open

            $requestPath = $this->urlModel->getProductRequestPath($product, $product->getCategory());
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/ProductPlugin.php by phan

Doc-block of $nestedFilter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $nestedFilter   Nested filter for the bucket.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/Histogram.php by phan

Doc-block of $filter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $filter       Bucket filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/Term.php by phan

Assigning ?\Magento\Framework\Search\Request\QueryInterface to property but \Smile\ElasticsuiteCore\Search\Request\Query\Filtered->query is \Smile\ElasticsuiteCore\Search\Request\QueryInterface
Open

        $this->query  = $query;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Filtered.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Missing should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Missing' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Missing.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Nested should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
Open

    public function setName($name): self
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Nested.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Range should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
Open

    public function setName($name): self
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Range.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Range should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Range' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Range.php by phan

Returning type string but getValues() is declared to return array
Open

        return $this->getValue();
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Terms.php by phan

Class \Smile\ElasticsuiteThesaurus\Model\ResourceModel\Thesaurus\Collection was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)
Open

                foreach ($this as $item) {
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

Suspicious array access to ?mixed
Open

            $labelsByThesaurusId[$currentTerm['thesaurus_id']][] = $label;
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

Doc-block of $sessionIndex in __construct contains phpdoc param type \Smile\ElasticsuiteTracker\Api\EventIndexInterface which is incompatible with the param type \Smile\ElasticsuiteTracker\Api\SessionIndexInterface declared in the signature
Open

     * @param \Smile\ElasticsuiteTracker\Api\EventIndexInterface   $sessionIndex Session index.
Severity: Minor
Found in src/module-elasticsuite-tracker/Cron/IndexLogEvent.php by phan

Possibly zero references to use statement for classlike/namespace SessionIndex (\Smile\ElasticsuiteTracker\Model\ResourceModel\SessionIndex)
Open

use Smile\ElasticsuiteTracker\Model\ResourceModel\SessionIndex;
Severity: Minor
Found in src/module-elasticsuite-tracker/Model/IndexManager.php by phan

Call to method getFacetSortOrder on non-class type null
Open

                $attribute->getFacetSortOrder() == ElasticBucketInterface::SORT_ORDER_MANUAL) {
Severity: Critical
Found in src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php by phan

Call to method getFrontend on non-class type null
Open

                $options = $attribute->getFrontend()->getSelectOptions();
Severity: Critical
Found in src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php by phan

Possibly zero references to use statement for classlike/namespace StoreInterface (\Magento\Store\Api\Data\StoreInterface)
Open

use Magento\Store\Api\Data\StoreInterface;
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Aggregations.php by phan

Returning type null but getOptimizer() is declared to return \Smile\ElasticsuiteCatalogOptimizer\Api\Data\OptimizerInterface
Open

            return $this->optimizer;
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Locator/RegistryLocator.php by phan

Returning type float but getMinValue() is declared to return int
Open

        return $minValue;
Severity: Minor
Found in src/module-elasticsuite-catalog/Block/Navigation/Renderer/PriceSlider.php by phan

Class \Smile\ElasticsuiteCatalog\Model\ResourceModel\Category\Fulltext\Collection was passed to foreach, but it does not extend Traversable and none of its declared properties are accessible from this context. (This check excludes dynamic properties)
Open

                foreach ($categoryCollection as $category) {
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Autocomplete/Category/DataProvider.php by phan
Severity
Category
Status
Source
Language