Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,375 of 1,375 total issues

Returning type \Magento\Framework\DB\Select but getVirtualSelectGlobal() is declared to return \Zend_Db_Select
Open

        return $select;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/ResourceModel/Product/Indexer/Fulltext/Datasource/CategoryData.php by phan

Argument 1 (appliedRootCategory) is \Magento\Catalog\Model\Category|null but \Smile\ElasticsuiteVirtualCategory\Model\Url::getVirtualCategorySubtreeUrl() takes \Magento\Catalog\Api\Data\CategoryInterface defined at /code/src/module-elasticsuite-virtual-category/Model/Url.php:200
Open

                $this->virtualCategoryRoot->getAppliedRootCategory(),
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Helper/BreadcrumbPlugin.php by phan

Doc-block of getRequestPath has declared return type string which is not a permitted replacement of the nullable return type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @return string
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Product/ProductPlugin.php by phan

Possibly zero references to use statement for classlike/namespace CollectionFactory (\Smile\ElasticsuiteVirtualCategory\Model\ResourceModel\Product\CollectionFactory)
Open

use Smile\ElasticsuiteVirtualCategory\Model\ResourceModel\Product\CollectionFactory;
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Widget/ProductsListPlugin.php by phan

Argument 1 (category) is \Magento\Catalog\Model\Category but \Smile\ElasticsuiteVirtualCategory\Model\Category\Filter\Provider::getQueryFilter() takes \Magento\Catalog\Api\Data\CategoryInterface defined at /code/src/module-elasticsuite-virtual-category/Model/Category/Filter/Provider.php:68
Open

            $query = $this->filterProvider->getQueryFilter($category);
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Collection/AddVirtualCategoryQuery.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\FunctionScore should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/FunctionScore.php by phan

Default value for int $includeOriginalDocs can't be false
Open

    public function __construct(
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/MoreLikeThis.php by phan

Default value for int $minimumShouldMatch can't be string
Open

    public function __construct(
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/MoreLikeThis.php by phan

Doc-block of $query in __construct is phpdoc param type \Magento\Framework\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\Search\Request\QueryInterface $query Negated query.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Not.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Not should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Not' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Not.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanContaining should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanContaining' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php by phan

Argument 1 (value) is array|array<int>|array{0:mixed}</int> but \Smile\ElasticsuiteCore\Search\Request\Query\Term::__construct() takes string defined at /code/src/module-elasticsuite-core/Search/Request/Query/Term.php:56
Open

        parent::__construct($values, $field, $name, $boost);
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Terms.php by phan

Returning type ?string but resolve() is declared to return string
Open

        return $resolverScopeCode;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/RelevanceConfig/App/Config/ScopeCodeResolver.php by phan

Doc-block of $nestedFilter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface $nestedFilter The filter applied to the nested sort.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/SortOrder/Nested.php by phan

Suspicious array access to ?mixed
Open

            $labelsByThesaurusId[$currentTerm['thesaurus_id']][] = $label;
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

Argument 5 (query) is null but \Smile\ElasticsuiteCore\Search\Request\Builder::create() takes \Smile\ElasticsuiteCore\Search\Request\QueryInterface|string defined at /code/src/module-elasticsuite-core/Search/Request/Builder.php:136
Open

        return $this->searchRequestBuilder->create($storeId, self::SEARCH_REQUEST_CONTAINER, 0, 0, null, [], [], $queryFilters);
Severity: Minor
Found in src/module-elasticsuite-tracker/Model/ResourceModel/SessionIndex.php by phan

Call with 2 arg(s) to \Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\QueryBuilder::getSearchQuery() which only takes 1 arg(s) defined at /code/src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product/QueryBuilder.php:78
Open

        return $this->queryBuilder->getSearchQuery($categoryCondition, $excludedCategories);
Severity: Info
Found in src/module-elasticsuite-virtual-category/Model/Rule.php by phan

Argument 1 (controller) is \Magento\CatalogRule\Controller\Adminhtml\Promo\Widget\Chooser but \Smile\ElasticsuiteVirtualCategory\Plugin\Catalog\Category\ChooserPlugin::getIds() takes \Magento\Backend\App\Action defined at /code/src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/ChooserPlugin.php:100
Open

            $this->getIds($controller)
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/ChooserPlugin.php by phan

Argument 1 (category) is \Magento\Framework\Model\AbstractModel but \Smile\ElasticsuiteVirtualCategory\Plugin\Catalog\Category\SaveProductsPositions::unserializeProductPositions() takes \Magento\Catalog\Model\Category defined at /code/src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/SaveProductsPositions.php:158
Open

            $this->unserializeProductPositions($category);
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Plugin/Catalog/Category/SaveProductsPositions.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Missing should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Missing' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Missing.php by phan
Severity
Category
Status
Source
Language