Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,357 of 1,357 total issues

Returning type \Magento\Framework\Pricing\Render but getPriceRenderer() is declared to return \Magento\Framework\View\Element\BlockInterface|bool
Open

        return $this->priceRenderer;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Autocomplete/Product/ItemFactory.php by phan

Assigning array to property but \Smile\ElasticsuiteCatalog\Model\Product\Indexer\Fulltext\Action\FullFactory->fullActionPool is \Magento\CatalogSearch\Model\Indexer\Fulltext\Action\Full
Open

        $this->fullActionPool = $fullActionPool;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Action/FullFactory.php by phan

Suspicious array access to \Magento\CatalogSearch\Model\Indexer\Fulltext\Action\Full
Open

        $fullActionClass = $this->fullActionPool['default'];
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Action/FullFactory.php by phan

Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getMappingFieldOptions() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:123
Open

        return $this->attributeHelper->getMappingFieldOptions($attribute);
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php by phan

Returning type void but aroundReindex() is declared to return \Magento\Catalog\Model\Category
Open

        return;
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Indexer/Category/Save/ReindexCategoryAfterSave.php by phan

Assigning array<int></int> to property but \Smile\ElasticsuiteCatalog\Search\Request\Product\Aggregation\Provider\FilterableAttributes\Modifier\Statistics->applicableAttributes is \Magento\Catalog\Model\ResourceModel\Eav\Attribute[]
Open

                    $this->applicableAttributes[] = $attribute;
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php by phan

Argument 1 (attribute) is \Magento\Catalog\Model\ResourceModel\Eav\Attribute but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getFilterField() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:338
Open

        return $this->mappingHelper->getFilterField($attribute);
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Attribute/Aggregation/DefaultAttribute.php by phan

Suspicious array access to float|int
Open

            $fields[$fieldName] = $this->mappingFieldFactory->create(['name' => $fieldName] + $fieldConfig);
Severity: Minor
Found in src/module-elasticsuite-core/Index/Indices/Config.php by phan

Returning type \Smile\ElasticsuiteCore\Search\Request\SortOrderInterface but getSortOrders() is declared to return \Smile\ElasticsuiteCore\Search\Request\SortOrderInterface[]
Open

        return $this->sortOrders;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request.php by phan

Doc-block of $filter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $filter       Bucket filter.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/QueryGroup.php by phan

Assigning ?\Magento\Framework\Search\Request\QueryInterface to property but \Smile\ElasticsuiteCore\Search\Request\Query\Filtered->filter is \Smile\ElasticsuiteCore\Search\Request\QueryInterface
Open

        $this->filter = $filter;
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Filtered.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanMultiTerm should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanMultiTerm' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanMultiTerm.php by phan

Possibly zero references to use statement for classlike/namespace ClientConfigurationInterface (\Smile\ElasticsuiteCore\Api\Client\ClientConfigurationInterface)
Open

use Smile\ElasticsuiteCore\Api\Client\ClientConfigurationInterface;
Severity: Minor
Found in src/module-elasticsuite-core/Setup/Validator.php by phan

Suspicious array access to null
Open

                $this->indicesStats[$indexName] = current($indexStatsResponse['indices']);
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Possibly zero references to use statement for classlike/namespace ThesaurusFactory (\Smile\ElasticsuiteThesaurus\Model\ThesaurusFactory)
Open

use Smile\ElasticsuiteThesaurus\Model\ThesaurusFactory;
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Controller/Adminhtml/Thesaurus/Save.php by phan

Argument 3 (baseWeight) is float but \Smile\ElasticsuiteThesaurus\Model\Index::getWeightedRewrites() takes int defined at /code/src/module-elasticsuite-thesaurus/Model/Index.php:351
Open

            $rewrites        = $this->getWeightedRewrites($synonymRewrites, $config->getSynonymWeightDivider(), $originalBoost);
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/Index.php by phan

Doc-block of $resource in __construct is phpdoc param type \Magento\Framework\Model\ResourceModel\AbstractResource which is not a permitted replacement of the nullable param type ?\Magento\Framework\Model\ResourceModel\AbstractResource declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource                    Resource.
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer.php by phan

Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getFilterField() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:338
Open

        return $this->attributeHelper->getFilterField($attribute);
Severity: Minor
Found in src/module-elasticsuite-catalog/Helper/Autocomplete.php by phan

Argument 1 (attributeCollection) is \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection but \Smile\ElasticsuiteCatalog\Model\ResourceModel\Eav\Indexer\Fulltext\Datasource\AbstractAttributeData::addIndexedFilterToAttributeCollection() takes \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection defined at /code/src/module-elasticsuite-catalog/Model/ResourceModel/Eav/Indexer/Fulltext/Datasource/AbstractAttributeData.php:75
Open

        $this->resourceModel->addIndexedFilterToAttributeCollection($attributeCollection);
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Eav/Indexer/Fulltext/Datasource/AbstractAttributeData.php by phan

Call to deprecated function \Smile\ElasticsuiteCatalog\Model\Product\Indexer\Fulltext\Datasource\InventoryData::getResourceModel() defined at /code/src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/InventoryData.php:88
Open

        $inventoryData = $this->getResourceModel()->loadInventoryData($storeId, array_keys($indexData));
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/InventoryData.php by phan
Severity
Category
Status
Source
Language