Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star

Showing 12,584 of 12,584 total issues

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/ibis" => "Ibis",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          res = ::Serrano.works(query: citation, limit: 1)&.dig("message", "items")&.first
Severity: Minor
Found in lib/vendor/serrano.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/the-american-journal-of-cardiology" => "The American Journal of Cardiology",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/plant-pathology" => "Plant Pathology",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Use if c['page'].present? instead of unless c['page'].blank?.
Open

      b[:pages] = c['page'] unless c['page'].blank?
Severity: Minor
Found in lib/vendor/serrano.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

Example: NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

Example: UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/law-and-society-review" => "Law & Society Review",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Use the new Ruby 1.9 hash syntax.
Open

gem "jquery-ui-rails", :git => 'https://github.com/jquery-ui-rails/jquery-ui-rails.git'
Severity: Minor
Found in Gemfile by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/revista-argentina-de-antropologia-biologica" => "Revista Argentina de Antropologia Biologica (Spanish)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/revista-brasileira-de-ciencia-do-solo" => "Revista Brasileira de Ciência do Solo",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/journal-of-magnetic-resonance-imaging" => "Journal Of Magnetic Resonance Imaging",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/fachhochschule-vorarlberg-note" => "Fachhochschule Vorarlberg (note)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/american-journal-of-epidemiology" => "American Journal of Epidemiology",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require_relative "application"
Severity: Minor
Found in config/environment.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/building-structure" => "Building Structure (Chinese)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/institut-francais-darcheologie-orientale-en" => "Institut français d'archéologie orientale (English)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/engineering-technology-and-applied-science-research" => "Engineering, Technology & Applied Science Research",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/tgm-wien-diplomarbeit-onorm" => "TGM Wien Diplomarbeit ÖNORM (German - Austria)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/steinbeis-hochschule-school-of-management-and-innovation" => "Steinbeis-Hochschule - School of Management & Innovation (German)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Use 2 (not 0) spaces for indentation.
Open

      raise('no attributes to trim') if !(attributes.map(&:to_s) - self.column_names).empty? # <- don't require AR connection
Severity: Minor
Found in config/initializers/application_record/nilify_blanks.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/acta-orthopaedica" => "Acta Orthopaedica",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }
Severity
Category
Status
Source
Language