Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star

Showing 12,579 of 12,579 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    if date_str.include? "/"
Severity: Minor
Found in lib/utilities/dates.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use end_month.present? instead of !end_month.blank?.
Open

    end_m = (!end_month.blank? and end_year.blank?)
Severity: Minor
Found in lib/utilities/dates.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

Example: NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

Example: UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Use if st_year.present? instead of unless st_year.blank?.
Open

    unless st_year.blank?
Severity: Minor
Found in lib/utilities/dates.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

Example: NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

Example: UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Do not write to stdout. Use Rails's logger if you want to log.
Open

    puts 'Lines per file: '
Severity: Minor
Found in lib/utilities/files.rb by rubocop

This cop checks for the use of output calls like puts and print

Example:

# bad
puts 'A debug message'
pp 'A debug message'
print 'A debug message'

# good
Rails.logger.debug 'A debug message'

Avoid more than 3 levels of block nesting.
Open

            if intg.length > 0  # have full case nn.mm
              sig = intg.length + mantissa.length
            else  # mantissa might have "leading" zeros
              decimal_lead_zeros = digits[1].length
              mantissa = digits[1].sub(/^[0]+/, '')
Severity: Minor
Found in lib/utilities/geo.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

            if digit_string[index + 1].to_i >= 5
              result = (result.to_i + 1).to_s # round if necessary
            end
Severity: Minor
Found in lib/utilities/geo.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          citeproc = ::Serrano.content_negotiation(ids: unurize_doi(citation), format: "citeproc-json") unless citation.nil?
Severity: Minor
Found in lib/vendor/serrano.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use if c['booktitle'].present? instead of unless c['booktitle'].blank?.
Open

      b[:booktitle] = ::Utilities::Strings.encode_with_utf8(c['booktitle']) unless c['booktitle'].blank?
Severity: Minor
Found in lib/vendor/serrano.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

Example: NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

Example: UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Use if c['abstract'].present? instead of unless c['abstract'].blank?.
Open

      unless c['abstract'].blank?
Severity: Minor
Found in lib/vendor/serrano.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

Example: NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

Example: UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Use 2 (not 1) spaces for indentation.
Open

   config.active_record.belongs_to_required_by_default = false
Severity: Minor
Found in config/application.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/university-of-aberdeen-school-of-education-harvard" => "University of Aberdeen - School of Education - Harvard",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/phytopathologia-mediterranea" => "Phytopathologia Mediterranea",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/korean-journal-of-anesthesiology" => "Korean Journal of Anesthesiology",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/ibis" => "Ibis",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/technische-universitat-dresden-erziehungswissenschaften-author-date" => "Technische Universität Dresden - Erziehungswissenschaften (author-date)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/european-cells-and-materials" => "European Cells & Materials",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/revista-brasileira-de-ciencia-do-solo" => "Revista Brasileira de Ciência do Solo",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/national-institute-of-technology-tiruchirappalli" => "National Institute of Technology, Tiruchirappalli",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/european-journal-of-human-genetics" => "European Journal of Human Genetics",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

"http://www.zotero.org/styles/mcgill-fr" => "Manuel canadien de la référence juridique 9e édition (Guide McGill, French - Canada)",
Severity: Minor
Found in config/initializers/constants/_controlled_vocabularies/csl_styles.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }
Severity
Category
Status
Source
Language