TabbycatDebate/tabbycat

View on GitHub

Showing 432 of 432 total issues

File emoji.py has 1528 lines of code (exceeds 600 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
import random
import logging

logger = logging.getLogger(__name__)
Severity: Major
Found in tabbycat/participants/emoji.py - About 3 days to fix

    Function _import has a Cognitive Complexity of 90 (exceeds 8 allowed). Consider refactoring.
    Open

        def _import(self, csvfile, model, interpreter=make_interpreter(), expect_unique=None):
            """Parses the object given in f, using the callable interpreter to parse
            each line, and passing the arguments to the given model's constructor.
            `csvfile` can be any object that is supported by csv.DictReader(), which
            includes file objects and lists of strings.
    Severity: Minor
    Found in tabbycat/importer/importers/base.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function import_results has a Cognitive Complexity of 74 (exceeds 8 allowed). Consider refactoring.
    Open

        def import_results(self):
            for round in self.root.findall('round'):
                consensus = self.preliminary_consensus if round.get('elimination') == 'false' else self.elimination_consensus
    
                for debate in round.findall('debate'):
    Severity: Minor
    Found in tabbycat/importer/archive.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method _import. (41)
    Open

        def _import(self, csvfile, model, interpreter=make_interpreter(), expect_unique=None):
            """Parses the object given in f, using the callable interpreter to parse
            each line, and passing the arguments to the given model's constructor.
            `csvfile` can be any object that is supported by csv.DictReader(), which
            includes file objects and lists of strings.
    Severity: Minor
    Found in tabbycat/importer/importers/base.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    File serializers.py has 800 lines of code (exceeds 600 allowed). Consider refactoring.
    Open

    from urllib import parse
    
    from django.db import IntegrityError
    from django.db.models import QuerySet
    from django.urls import get_script_prefix, resolve, Resolver404
    Severity: Major
    Found in tabbycat/api/serializers.py - About 6 hrs to fix

      Function setSorting has a Cognitive Complexity of 47 (exceeds 8 allowed). Consider refactoring.
      Open

          setSorting (state, sortType) {
            let debatesArray = Object.values(state.debatesOrPanels)
      
            if (debatesArray.length === 0) {
              return // e.g. Preformed Panels page prior to use
      Severity: Minor
      Found in tabbycat/templates/allocations/DragAndDropStore.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function add_debate_adjudicators_column has a Cognitive Complexity of 46 (exceeds 8 allowed). Consider refactoring.
      Open

          def add_debate_adjudicators_column(self, debates, title="Adjudicators",
                  show_splits=False, highlight_adj=None, for_admin=False):
              da_data = []
      
              def construct_text(adjs_data):
      Severity: Minor
      Found in tabbycat/utils/tables.py - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def import_rounds(self, f):
              round_interpreter_part = make_interpreter(
                  tournament=self.tournament,
                  stage=self.lookup_round_stage,
                  draw_type=self.lookup_draw_type,
      Severity: Major
      Found in tabbycat/importer/importers/anorak.py and 1 other location - About 6 hrs to fix
      tabbycat/importer/importers/boots.py on lines 72..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def import_rounds(self, f):
              interpreter_part = make_interpreter(
                  tournament=self.tournament,
                  stage=self.lookup_round_stage,
                  draw_type=self.lookup_draw_type,
      Severity: Major
      Found in tabbycat/importer/importers/boots.py and 1 other location - About 6 hrs to fix
      tabbycat/importer/importers/anorak.py on lines 78..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File tables.py has 787 lines of code (exceeds 600 allowed). Consider refactoring.
      Open

      import logging
      import warnings
      
      from django.contrib.humanize.templatetags.humanize import ordinal
      from django.template.loader import render_to_string
      Severity: Major
      Found in tabbycat/utils/tables.py - About 6 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def add_message(self, nsaved, ndeleted):
                if nsaved > 0:
                    messages.success(self.request, ngettext(
                        "Saved %(count)d adjudicator-institution conflict.",
                        "Saved %(count)d adjudicator-institution conflicts.",
        Severity: Major
        Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
        tabbycat/adjallocation/views.py on lines 195..209
        tabbycat/adjallocation/views.py on lines 235..249
        tabbycat/adjallocation/views.py on lines 316..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def add_message(self, nsaved, ndeleted):
                if nsaved > 0:
                    messages.success(self.request, ngettext(
                        "Saved %(count)d team-institution conflict.",
                        "Saved %(count)d team-institution conflicts.",
        Severity: Major
        Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
        tabbycat/adjallocation/views.py on lines 195..209
        tabbycat/adjallocation/views.py on lines 235..249
        tabbycat/adjallocation/views.py on lines 274..288

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def add_message(self, nsaved, ndeleted):
                if nsaved > 0:
                    messages.success(self.request, ngettext(
                        "Saved %(count)d adjudicator-team conflict.",
                        "Saved %(count)d adjudicator-team conflicts.",
        Severity: Major
        Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
        tabbycat/adjallocation/views.py on lines 235..249
        tabbycat/adjallocation/views.py on lines 274..288
        tabbycat/adjallocation/views.py on lines 316..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def add_message(self, nsaved, ndeleted):
                if nsaved > 0:
                    messages.success(self.request, ngettext(
                        "Saved %(count)d adjudicator-adjudicator conflict.",
                        "Saved %(count)d adjudicator-adjudicator conflicts.",
        Severity: Major
        Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
        tabbycat/adjallocation/views.py on lines 195..209
        tabbycat/adjallocation/views.py on lines 274..288
        tabbycat/adjallocation/views.py on lines 316..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function add_feedback has a Cognitive Complexity of 43 (exceeds 8 allowed). Consider refactoring.
        Open

        def add_feedback(debate, submitter_type, user, probability=1.0, discarded=False, confirmed=False):
            """Adds feedback to a debate.
            Specifically, adds feedback from both teams on the chair, and from every
            adjudicator on every other adjudicator.
        
        
        Severity: Minor
        Found in tabbycat/adjfeedback/dbutils.py - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Cyclomatic complexity is too high in function calculate_anticipated_draw. (36)
        Open

        def calculate_anticipated_draw(round):
            """Calculates an anticipated draw for the next round, based on the draw for
            the last round. Returns a list of tuples
                `(bracket_min, bracket_max, liveness)`,
            being the minimum and maximum brackets possible for that room, and the

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if Adjudicator.objects.exclude(institution__region__isnull=True).exists():
                data_sets['adjudicators_region'].append(compile_grouped_counts(_("All"), adjudicators,
                        F('institution__region__id'), region_values, region_labels))
        
                if t.pref('public_breaking_adjs') is True or for_public is False:
        Severity: Major
        Found in tabbycat/standings/diversity.py and 1 other location - About 5 hrs to fix
        tabbycat/standings/diversity.py on lines 150..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if Team.objects.exclude(institution__region__isnull=True).exists():
                data_sets['speakers_region'].append(compile_grouped_counts(_("All Speakers"), speakers,
                        F('team__institution__region__id'), region_values, region_labels))
        
                if t.pref('public_breaking_teams') is True or for_public is False:
        Severity: Major
        Found in tabbycat/standings/diversity.py and 1 other location - About 5 hrs to fix
        tabbycat/standings/diversity.py on lines 186..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function add_result has a Cognitive Complexity of 41 (exceeds 8 allowed). Consider refactoring.
        Open

        def add_result(debate, submitter_type, user, discarded=False, confirmed=False, reply_random=False):
            """Adds a ballot set to a debate.
        
            ``debate`` is the Debate to which the ballot set should be added.
            ``submitter_type`` is a valid value of BallotSubmission.submitter_type.
        Severity: Minor
        Found in tabbycat/results/dbutils.py - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Cyclomatic complexity is too high in method run_allocation. (33)
        Open

            def run_allocation(self):
        
                # Sort voting adjudicators in descending order by score
                voting = [a for a in self.adjudicators if a._weighted_score >= self.min_voting_score and not a.trainee]
                random.shuffle(voting)

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Severity
        Category
        Status
        Source
        Language