TabbycatDebate/tabbycat

View on GitHub

Showing 428 of 428 total issues

File emoji.py has 1647 lines of code (exceeds 600 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
import random
import logging
from typing import Tuple, Optional

Severity: Major
Found in tabbycat/participants/emoji.py - About 3 days to fix

    Function _import has a Cognitive Complexity of 90 (exceeds 8 allowed). Consider refactoring.
    Open

        def _import(self, csvfile, model, interpreter=make_interpreter(), expect_unique=None):
            """Parses the object given in f, using the callable interpreter to parse
            each line, and passing the arguments to the given model's constructor.
            `csvfile` can be any object that is supported by csv.DictReader(), which
            includes file objects and lists of strings.
    Severity: Minor
    Found in tabbycat/importer/importers/base.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File serializers.py has 1091 lines of code (exceeds 600 allowed). Consider refactoring.
    Open

    from collections import OrderedDict
    from collections.abc import Mapping
    from functools import partialmethod
    
    from django.contrib.auth import get_user_model
    Severity: Major
    Found in tabbycat/api/serializers.py - About 1 day to fix

      Function import_results has a Cognitive Complexity of 74 (exceeds 8 allowed). Consider refactoring.
      Open

          def import_results(self):
              for round in self.root.findall('round'):
                  consensus = self.preliminary_consensus if round.get('elimination') == 'false' else self.elimination_consensus
      
                  for debate in round.findall('debate'):
      Severity: Minor
      Found in tabbycat/importer/archive.py - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File views.py has 962 lines of code (exceeds 600 allowed). Consider refactoring.
      Open

      from copy import deepcopy
      from itertools import groupby
      
      from asgiref.sync import async_to_sync
      from channels.layers import get_channel_layer
      Severity: Major
      Found in tabbycat/api/views.py - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            class EventType(models.TextChoices):
                POINTS = 'p', _("team points")
                BALLOTS_CONFIRMED = 'c', _("ballot confirmed")
                FEEDBACK_URL = 'f', _("feedback URL")
                BALLOT_URL = 'b', _("ballot URL")
        Severity: Major
        Found in tabbycat/notifications/models.py and 1 other location - About 7 hrs to fix
        tabbycat/notifications/models.py on lines 87..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 138.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            class EventType(models.TextChoices):
                PROCESSED = 'processed', _("Processed")
                DROPPED = 'dropped', _("Dropped")
                DEFERRED = 'deferred', _("Deferred")
                DELIVERED = 'delivered', _("Delivered")
        Severity: Major
        Found in tabbycat/notifications/models.py and 1 other location - About 7 hrs to fix
        tabbycat/notifications/models.py on lines 45..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 138.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File tables.py has 843 lines of code (exceeds 600 allowed). Consider refactoring.
        Open

        import logging
        import warnings
        
        from django.contrib.humanize.templatetags.humanize import ordinal
        from django.db.models import Exists, OuterRef, Prefetch
        Severity: Major
        Found in tabbycat/utils/tables.py - About 7 hrs to fix

          Cyclomatic complexity is too high in method _import. (41)
          Open

              def _import(self, csvfile, model, interpreter=make_interpreter(), expect_unique=None):
                  """Parses the object given in f, using the callable interpreter to parse
                  each line, and passing the arguments to the given model's constructor.
                  `csvfile` can be any object that is supported by csv.DictReader(), which
                  includes file objects and lists of strings.
          Severity: Minor
          Found in tabbycat/importer/importers/base.py by radon

          Cyclomatic Complexity

          Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

          Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

          Construct Effect on CC Reasoning
          if +1 An if statement is a single decision.
          elif +1 The elif statement adds another decision.
          else +0 The else statement does not cause a new decision. The decision is at the if.
          for +1 There is a decision at the start of the loop.
          while +1 There is a decision at the while statement.
          except +1 Each except branch adds a new conditional path of execution.
          finally +0 The finally block is unconditionally executed.
          with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
          assert +1 The assert statement internally roughly equals a conditional statement.
          Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
          Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

          Source: http://radon.readthedocs.org/en/latest/intro.html

          Function setSorting has a Cognitive Complexity of 47 (exceeds 8 allowed). Consider refactoring.
          Open

              setSorting (state, sortType) {
                let debatesArray = Object.values(state.debatesOrPanels)
          
                if (debatesArray.length === 0) {
                  return // e.g. Preformed Panels page prior to use
          Severity: Minor
          Found in tabbycat/templates/allocations/DragAndDropStore.js - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for adj, team in product(debate.adjudicators.all(), debate.teams):
          
                      if conflicts.personal_conflict_adj_team(adj, team):
                          conflict_messages[debate].append(("danger", _(
                              "Conflict: <strong>%(adjudicator)s</strong> & <strong>%(team)s</strong> "
          Severity: Major
          Found in tabbycat/adjallocation/utils.py and 1 other location - About 6 hrs to fix
          tabbycat/adjallocation/utils.py on lines 43..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for adj1, adj2 in combinations(debate.adjudicators.all(), 2):
          
                      if conflicts.personal_conflict_adj_adj(adj1, adj2):
                          conflict_messages[debate].append(("danger", _(
                              "Conflict: <strong>%(adjudicator1)s</strong> & <strong>%(adjudicator2)s</strong> "
          Severity: Major
          Found in tabbycat/adjallocation/utils.py and 1 other location - About 6 hrs to fix
          tabbycat/adjallocation/utils.py on lines 25..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function add_debate_adjudicators_column has a Cognitive Complexity of 46 (exceeds 8 allowed). Consider refactoring.
          Open

              def add_debate_adjudicators_column(self, debates, title="Adjudicators",
                      show_splits=False, highlight_adj=None, for_admin=False):
                  da_data = []
          
                  def construct_text(adjs_data):
          Severity: Minor
          Found in tabbycat/utils/tables.py - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def import_rounds(self, f):
                  round_interpreter_part = make_interpreter(
                      tournament=self.tournament,
                      stage=self.lookup_round_stage,
                      draw_type=self.lookup_draw_type,
          Severity: Major
          Found in tabbycat/importer/importers/anorak.py and 1 other location - About 6 hrs to fix
          tabbycat/importer/importers/boots.py on lines 72..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def import_rounds(self, f):
                  interpreter_part = make_interpreter(
                      tournament=self.tournament,
                      stage=self.lookup_round_stage,
                      draw_type=self.lookup_draw_type,
          Severity: Major
          Found in tabbycat/importer/importers/boots.py and 1 other location - About 6 hrs to fix
          tabbycat/importer/importers/anorak.py on lines 78..92

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def add_message(self, nsaved, ndeleted):
                  if nsaved > 0:
                      messages.success(self.request, ngettext(
                          "Saved %(count)d team-institution conflict.",
                          "Saved %(count)d team-institution conflicts.",
          Severity: Major
          Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
          tabbycat/adjallocation/views.py on lines 195..209
          tabbycat/adjallocation/views.py on lines 235..249
          tabbycat/adjallocation/views.py on lines 274..288

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def add_message(self, nsaved, ndeleted):
                  if nsaved > 0:
                      messages.success(self.request, ngettext(
                          "Saved %(count)d adjudicator-team conflict.",
                          "Saved %(count)d adjudicator-team conflicts.",
          Severity: Major
          Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
          tabbycat/adjallocation/views.py on lines 235..249
          tabbycat/adjallocation/views.py on lines 274..288
          tabbycat/adjallocation/views.py on lines 316..330

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def add_message(self, nsaved, ndeleted):
                  if nsaved > 0:
                      messages.success(self.request, ngettext(
                          "Saved %(count)d adjudicator-adjudicator conflict.",
                          "Saved %(count)d adjudicator-adjudicator conflicts.",
          Severity: Major
          Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
          tabbycat/adjallocation/views.py on lines 195..209
          tabbycat/adjallocation/views.py on lines 274..288
          tabbycat/adjallocation/views.py on lines 316..330

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def add_message(self, nsaved, ndeleted):
                  if nsaved > 0:
                      messages.success(self.request, ngettext(
                          "Saved %(count)d adjudicator-institution conflict.",
                          "Saved %(count)d adjudicator-institution conflicts.",
          Severity: Major
          Found in tabbycat/adjallocation/views.py and 3 other locations - About 6 hrs to fix
          tabbycat/adjallocation/views.py on lines 195..209
          tabbycat/adjallocation/views.py on lines 235..249
          tabbycat/adjallocation/views.py on lines 316..330

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File result.py has 783 lines of code (exceeds 600 allowed). Consider refactoring.
          Open

          """Debate result classes.
          
          Debate result classes aggregate scoresheets to produce results for an entire
          debate, and interact with the database with respect to models recording scores
          given in the debate. They do not deal with metadata (like motions), only scores
          Severity: Major
          Found in tabbycat/results/result.py - About 6 hrs to fix
            Severity
            Category
            Status
            Source
            Language