TabbycatDebate/tabbycat

View on GitHub
tabbycat/api/serializers.py

Summary

Maintainability
A
2 hrs
Test Coverage
F
50%

File serializers.py has 603 lines of code (exceeds 600 allowed). Consider refactoring.
Open

from urllib import parse

from django.db import IntegrityError
from django.db.models import QuerySet
from django.urls import get_script_prefix, resolve, Resolver404
Severity: Major
Found in tabbycat/api/serializers.py - About 2 hrs to fix

    Function validate has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

        def validate(self, data):
            source = data.pop('source')
            debate = data.pop('debate')
    
            # Test answers for correct source
    Severity: Minor
    Found in tabbycat/api/serializers.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status