TabbycatDebate/tabbycat

View on GitHub
tabbycat/draw/models.py

Summary

Maintainability
C
7 hrs
Test Coverage
F
59%

Function get_result_display has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
Open

    def get_result_display(self):
        if self.team.tournament.pref('teams_in_debate') == 'bp':
            if self.points == 3:
                return gettext("placed 1st")
            elif self.points == 2:
Severity: Minor
Found in tabbycat/draw/models.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return gettext("won")
Severity: Major
Found in tabbycat/draw/models.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return gettext("result unknown")
    Severity: Major
    Found in tabbycat/draw/models.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return gettext("lost")
      Severity: Major
      Found in tabbycat/draw/models.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return gettext("result unknown")
        Severity: Major
        Found in tabbycat/draw/models.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @property
              def win(self):
                  """Convenience function. Returns True if this team won, False if this
                  team lost, or None if there isn't a confirmed result.
          
          
          Severity: Major
          Found in tabbycat/draw/models.py and 1 other location - About 1 hr to fix
          tabbycat/draw/models.py on lines 343..357

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @property
              def points(self):
                  """Convenience function. Returns the number of points this team received
                  or None if there isn't a confirmed result.
          
          
          Severity: Major
          Found in tabbycat/draw/models.py and 1 other location - About 1 hr to fix
          tabbycat/draw/models.py on lines 327..341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              SIDE_CHOICES = ((SIDE_AFF, _("affirmative")),
                              (SIDE_NEG, _("negative")),
                              (SIDE_OG, _("opening government")),
                              (SIDE_OO, _("opening opposition")),
                              (SIDE_CG, _("closing government")),
          Severity: Minor
          Found in tabbycat/draw/models.py and 1 other location - About 50 mins to fix
          tabbycat/breakqual/models.py on lines 81..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if not self.sides_confirmed:
                      teams_list = ", ".join([dt.team.short_name for dt in self.debateteam_set.all()])
                      # Translators: This is appended to a list of teams, e.g. "Auckland
                      # 1, Vic Wellington 1 (sides not confirmed)". Mind the leading
                      # space.
          Severity: Minor
          Found in tabbycat/draw/models.py and 1 other location - About 40 mins to fix
          tabbycat/draw/models.py on lines 99..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if not self.sides_confirmed:
                      teams_list = ", ".join([dt.team.code_name for dt in self.debateteam_set.all()])
                      return teams_list + gettext(" (sides not confirmed)")
          Severity: Minor
          Found in tabbycat/draw/models.py and 1 other location - About 40 mins to fix
          tabbycat/draw/models.py on lines 71..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status