Sign upLogin

TheCorrespondingSquares/chess-app

View on GitHub
Star

Showing 927 of 927 total issues

Tab detected.
Open

          let!(:game1) { FactoryGirl.create(:game, white_player_id: user.id)}
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Line is too long. [98/80]
Open

    let(:king) { FactoryGirl.create(:king, color: "White", x_pos: 7, y_pos: 7, game_id: game.id) }
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Line is too long. [98/80]
Open

    let(:king) { FactoryGirl.create(:king, color: "White", x_pos: 7, y_pos: 7, game_id: game.id) }
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Space missing inside }.
Open

  let(:game) { FactoryGirl.create(:game, black_player_id: user.id)}
Severity: Minor
Found in spec/models/knight_spec.rb by rubocop

Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

Example: EnforcedStyle: space (default)

# The `space` style enforces that block braces have
# surrounding space.

# bad
some_array.each {puts e}

# good
some_array.each { puts e }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that block braces don't
# have surrounding space.

# bad
some_array.each { puts e }

# good
some_array.each {puts e}

Example: EnforcedStyleForEmptyBraces: no_space (default)

# The `no_space` EnforcedStyleForEmptyBraces style enforces that
# block braces don't have a space in between when empty.

# bad
some_array.each {   }
some_array.each {  }
some_array.each { }

# good
some_array.each {}

Example: EnforcedStyleForEmptyBraces: space

# The `space` EnforcedStyleForEmptyBraces style enforces that
# block braces have at least a spece in between when empty.

# bad
some_array.each {}

# good
some_array.each { }
some_array.each {  }
some_array.each {   }

Example: SpaceBeforeBlockParameters: true (default)

# The SpaceBeforeBlockParameters style set to `true` enforces that
# there is a space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each {|n| n * 2 }

# good
[1, 2, 3].each { |n| n * 2 }

Example: SpaceBeforeBlockParameters: true

# The SpaceBeforeBlockParameters style set to `false` enforces that
# there is no space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each { |n| n * 2 }

# good
[1, 2, 3].each {|n| n * 2 }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        context "for valid move" do
Severity: Minor
Found in spec/models/rook_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Space missing inside {.
Open

    let(:knight) {FactoryGirl.create(:knight, x_pos: 2, y_pos: 0, color: 'White', game_id: game.id)}
Severity: Minor
Found in spec/models/knight_spec.rb by rubocop

Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

Example: EnforcedStyle: space (default)

# The `space` style enforces that block braces have
# surrounding space.

# bad
some_array.each {puts e}

# good
some_array.each { puts e }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that block braces don't
# have surrounding space.

# bad
some_array.each { puts e }

# good
some_array.each {puts e}

Example: EnforcedStyleForEmptyBraces: no_space (default)

# The `no_space` EnforcedStyleForEmptyBraces style enforces that
# block braces don't have a space in between when empty.

# bad
some_array.each {   }
some_array.each {  }
some_array.each { }

# good
some_array.each {}

Example: EnforcedStyleForEmptyBraces: space

# The `space` EnforcedStyleForEmptyBraces style enforces that
# block braces have at least a spece in between when empty.

# bad
some_array.each {}

# good
some_array.each { }
some_array.each {  }
some_array.each {   }

Example: SpaceBeforeBlockParameters: true (default)

# The SpaceBeforeBlockParameters style set to `true` enforces that
# there is a space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each {|n| n * 2 }

# good
[1, 2, 3].each { |n| n * 2 }

Example: SpaceBeforeBlockParameters: true

# The SpaceBeforeBlockParameters style set to `false` enforces that
# there is no space between `{` and `|`. Overrides `EnforcedStyle`
# if there is a conflict.

# bad
[1, 2, 3].each { |n| n * 2 }

# good
[1, 2, 3].each {|n| n * 2 }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  describe "knight#valid_move?" do
Severity: Minor
Found in spec/models/knight_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open
Severity: Minor
Found in spec/models/knight_spec.rb by rubocop

Line is too long. [100/80]
Open

    let(:knight) {FactoryGirl.create(:knight, x_pos: 2, y_pos: 0, color: 'White', game_id: game.id)}
Severity: Minor
Found in spec/models/knight_spec.rb by rubocop

Inconsistent indentation detected.
Open

  describe "#check?" do
    let(:game) { FactoryGirl.create(:game, white_player_id: user.id)}
    let(:king) { FactoryGirl.create(:king, color: "White", x_pos: 7, y_pos: 7, game_id: game.id) }
    before(:each) { game.pieces.destroy_all }
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Carriage return character detected.
Open

require 'rails_helper'

RSpec.describe King, type: :model do
Severity: Minor
Found in spec/models/king_spec.rb by rubocop

Inconsistent indentation detected.
Open

    context 'when all existing games are unavailable' do
          let!(:game1) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id)}
          let!(:game2) { FactoryGirl.create(:game, black_player_id: user2.id, white_player_id: user.id)}

          it 'show any game' do
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

  describe '.available' do
      let!(:user2) { FactoryGirl.create(:user) }

    context 'when some games are not available' do
          let!(:game1) { FactoryGirl.create(:game, white_player_id: user.id) }
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 0) spaces for indentation.
Open

          let!(:game1) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id)}
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [98/80]
Open

          let!(:game2) { FactoryGirl.create(:game, black_player_id: user2.id, white_player_id: user.id)}
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Tab detected.
Open

          let!(:game2) { FactoryGirl.create(:game, black_player_id: user2.id)}
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Line is too long. [133/80]
Open

      let!(:piece_making_check) { FactoryGirl.create(:queen, color: "Black", captured: false, x_pos: 2, y_pos: 3, game_id: game.id) }
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Tab detected.
Open

          let!(:game1) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id)}
Severity: Minor
Found in spec/models/game_spec.rb by rubocop

Trailing whitespace detected.
Open

end
Severity: Minor
Found in spec/models/concerns/squares_spec.rb by rubocop

Extra empty line detected at block body end.
Open


end
Severity: Minor
Found in spec/models/concerns/movements_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end
Severity
Category
Status
Source
Language