Sign upLogin

TheCorrespondingSquares/chess-app

View on GitHub
Star

Showing 927 of 927 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        white_pawn = FactoryGirl.create(:pawn, color: "White", x_pos: 3, y_pos: 4, game_id: game.id)
Severity: Minor
Found in spec/models/pawn_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        expect(flash[:alert]).to match("Sorry, that move would leave your King in check.")
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        let!(:bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 5, y_pos: 2, game_id: game.id) }
Severity: Minor
Found in spec/models/queen_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use 2 (not 1) spaces for indentation.
Open

      let!(:user) { FactoryGirl.create(:user) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Inconsistent indentation detected.
Open

    it 'should update the result the winner is Black and notify the game is over' do
      game.pieces.destroy_all
      game.pieces.create(name: "King", color: "Black", x_pos: 0, y_pos: 0)
      game.pieces.create(name: "Bishop", color: "White", x_pos: 4, y_pos: 4)
      game.pieces.create(name: "Bishop", color: "Black", x_pos: 0, y_pos: 1)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    name "This Game Rules!"
Severity: Minor
Found in spec/factories/games.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    name "Bishop"
Severity: Minor
Found in spec/factories/pieces.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open

    end
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Line is too long. [87/80]
Open

      it 'should not allow Black piece/player to move on White piece/player\'s turn' do
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Line is too long. [90/80]
Open

        patch :update, params: { game_id: game.id, id: white_pawn.id, x_pos: 4, y_pos: 2 }
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      let!(:white_king) { FactoryGirl.create(:king, color: "White", x_pos: 4, y_pos: 0, game_id: game.id) }
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use 2 (not 1) spaces for indentation.
Open

          get :show, params: { id: game.id }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Line is too long. [113/80]
Open

        let!(:pawn2) { FactoryGirl.create(:pawn, color: "Black", x_pos: 4, y_pos: 4, game_id: game.id, turn: 1) }
Severity: Minor
Found in spec/models/pawn_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      let!(:pawn2) {FactoryGirl.create(:pawn, color: "White", x_pos: 2, y_pos: 4, game_id: game.id, turn: 2)}
Severity: Minor
Found in spec/models/pawn_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    context "for a valid enpassant move" do
Severity: Minor
Found in spec/models/pawn_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    name "Pawn"
Severity: Minor
Found in spec/factories/pieces.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at block body end.
Open


    end
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Line is too long. [98/80]
Open

    let(:rook) { FactoryGirl.create(:rook, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop

Line is too long. [87/80]
Open

      it 'should not allow White piece/player to move on Black piece/player\'s turn' do
Severity: Minor
Found in spec/controllers/pieces_controller_spec.rb by rubocop
Severity
Category
Status
Source
Language