Sign upLogin

TheRole/TheRoleApi

View on GitHub
Star
app/models/concerns/the_role/api/user.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method owner? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def owner? obj
        return false unless obj
        return true  if admin?

        section_name = obj.class.to_s.tableize
Severity: Minor
Found in app/models/concerns/the_role/api/user.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return id == obj[:user][:id] if obj[:user]
Severity: Major
Found in app/models/concerns/the_role/api/user.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return id == obj[:user_id]   if obj[:user_id]
    Severity: Major
    Found in app/models/concerns/the_role/api/user.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return id == obj.user_id     if obj.respond_to? :user_id
      Severity: Major
      Found in app/models/concerns/the_role/api/user.rb - About 30 mins to fix

        Method set_default_role has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def set_default_role
        unless role
          default_role = ::Role.find_by_name(TheRole.config.default_user_role)
          self.role = default_role if default_role
        end
        Severity: Minor
        Found in app/models/concerns/the_role/api/user.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status