Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star

Showing 2,245 of 2,245 total issues

Missing class import via use statement (line '612', column '31').
Open

                    throw new \RuntimeException(sprintf("Email address '%s' is not valid!", $emailAddr));
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getPassword has a boolean flag argument $stars, which is a certain sign of a Single Responsibility Principle violation.
Open

function getPassword($stars = false)
Severity: Minor
Found in src/Libs/Helpers/functions.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method restoreFolder has a boolean flag argument $isFull, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function restoreFolder($src, $target, $isFull = false)
Severity: Minor
Found in src/Application/Restore.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method checkRequirements has a boolean flag argument $ignoreMaxVersion, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function checkRequirements(Instance $instance, bool $ignoreMaxVersion = false): bool
Severity: Minor
Found in src/Application/Tiki/Versions/TikiRequirements.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '829', column '23').
Open

            throw new \RuntimeException(implode(PHP_EOL, $errors));
Severity: Minor
Found in src/Application/Tiki.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method clearCache has a boolean flag argument $all, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function clearCache($all = false)
Severity: Minor
Found in src/Application/Tiki.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '72', column '31').
Open

                    throw new \RuntimeException('Profile name cannot be empty');
Severity: Minor
Found in src/Command/ApplyProfileCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '227', column '31').
Open

                    throw new \Exception('Unable to install. An application was detected in this instance.');
Severity: Minor
Found in src/Command/CreateInstanceCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method isValidVersion has a boolean flag argument $ignoreMaxVersion, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function isValidVersion($version, $ignoreMaxVersion = false): bool
Severity: Minor
Found in src/Application/Tiki/Versions/SoftwareRequirement.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '1129', column '23').
Open

            throw new \Exception("NPM install failed.\nCheck " . $_ENV['TRIM_OUTPUT'] . " for more details.");
Severity: Minor
Found in src/Application/Tiki.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getFileChanges has a boolean flag argument $refresh, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getFileChanges($refresh = false)
Severity: Minor
Found in src/Application/Tiki.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '215', column '27').
Open

                throw new \Exception($error);
Severity: Minor
Found in src/Command/CreateInstanceCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '81', column '27').
Open

                throw new \RuntimeException('Patch ID cannot be empty.');
Severity: Minor
Found in src/Command/DeletePatchCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '368', column '23').
Open

            throw new \RuntimeException(
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '91', column '23').
Open

            throw new \RuntimeException('Unable to initialize Tiki application. Please check if selected instance is a Tiki instance.');
Severity: Minor
Found in src/Command/CheckoutCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '351', column '23').
Open

            throw new \RuntimeException(
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '391', column '23').
Open

            throw new \RuntimeException(
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '500', column '19').
Open

        throw new Exception('Invalid composer installer signature.');
Severity: Minor
Found in src/Libs/Helpers/functions.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 673.
Open

    public function applyPatch(Patch $patch, $options)
    {
        $access = $this->instance->getBestAccess('scripting');
        $vcsType = $this->vcs_instance->getIdentifier();
        $can_patch = $access->hasExecutable('patch');
Severity: Minor
Found in src/Application/Tiki.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '128', column '23').
Open

            throw new \RuntimeException('Package name cannot be empty.');
Severity: Minor
Found in src/Command/ApplyPatchCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language