Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star

Showing 2,245 of 2,245 total issues

Missing class import via use statement (line '154', column '27').
Open

                throw new \Exception($error);
Severity: Minor
Found in src/Command/ImportInstanceCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getInstances has a boolean flag argument $excludeBlank, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getInstances($type = 'all', $excludeBlank = false)
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '385', column '23').
Open

            throw new \RuntimeException(
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '99', column '27').
Open

                throw new \Exception('Failed to retrieve phar file.');
Severity: Minor
Found in src/Manager/Update/Phar.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method info has a boolean flag argument $raw, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function info($targetFolder, $raw = false)
Severity: Minor
Found in src/Libs/VersionControl/Src.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method exec has a boolean flag argument $isPriorityCommand, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function exec($targetFolder, $toAppend, $isPriorityCommand = false)
Severity: Minor
Found in src/Libs/VersionControl/Git.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '57', column '23').
Open

            throw new \Exception('Error extracting files.');
Severity: Minor
Found in src/Manager/Update/Src.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '86', column '27').
Open

                throw new \RuntimeException(sprintf('Patch %s not found.', $patchId));
Severity: Minor
Found in src/Command/DeletePatchCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method runCommands has a boolean flag argument $output, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function runCommands($commands, $output = false)
Severity: Minor
Found in src/Libs/Host/SSH.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '63', column '23').
Open

            throw new \RuntimeException('No Tiki instances available to check for local patches.');
Severity: Minor
Found in src/Command/ListPatchCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getUntrackedFiles has a boolean flag argument $includeIgnore, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getUntrackedFiles($folder, $includeIgnore = false)
Severity: Minor
Found in src/Libs/VersionControl/Git.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getUntrackedFiles has a boolean flag argument $includeIgnore, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getUntrackedFiles($folder, $includeIgnore = false)
Severity: Minor
Found in src/Libs/VersionControl/Svn.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '68', column '31').
Open

                    throw new \RuntimeException('Patch ID cannot be empty');
Severity: Minor
Found in src/Command/DeletePatchCommand.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getInstancesInfo has a boolean flag argument $all_infos, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getInstancesInfo(array $instances, bool $all_infos = false): ?array
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '405', column '23').
Open

            throw new \RuntimeException(
Severity: Minor
Found in src/Command/Helper/CommandHelper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method runCommands has a boolean flag argument $output, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function runCommands($commands, $output = false)
Severity: Minor
Found in src/Libs/Host/SSHSeclibAdapter.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method write has a boolean flag argument $newline, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL)
Severity: Minor
Found in src/Style/TikiManagerStyle.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method stashPop has a boolean flag argument $revertOnFailure, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function stashPop(string $targetFolder, bool $revertOnFailure = true)
Severity: Minor
Found in src/Libs/VersionControl/Git.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method info has a boolean flag argument $raw, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function info($targetFolder, $raw = false)
Severity: Minor
Found in src/Libs/VersionControl/Svn.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getIdentifier has a boolean flag argument $isCapitalized, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getIdentifier($isCapitalized = false)
Severity: Minor
Found in src/Libs/VersionControl/VersionControlSystem.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language