Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star

Showing 2,085 of 2,085 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset($instancesInfo) && empty($input->getOption('exclude'))) {
            CommandHelper::renderInstancesTable($output, $instancesInfo);
            $this->io->newLine();
            $this->io->writeln('<comment>In case you want to ignore more than one instance, please use a comma (,) between the values</comment>');
Severity: Major
Found in src/Command/SetupWatchManagerCommand.php and 2 other locations - About 3 hrs to fix
src/Command/SetupBackupManagerCommand.php on lines 67..84
src/Command/WatchInstanceCommand.php on lines 62..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $currentCwd = getcwd();
        $instancesOpt = $input->getOption('instances');
        $excludesOpt = $input->getOption('exclude');
Severity: Minor
Found in src/Command/StatsInstanceCommand.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (empty($this->instancesInfo)) {
            $output->writeln('<comment>No instances available to detect.</comment>');
            return;
Severity: Minor
Found in src/Command/DetectInstanceCommand.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function applyPatch has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function applyPatch(Patch $patch, $options)
    {
        $access = $this->instance->getBestAccess('scripting');
        $vcsType = $this->vcs_instance->getIdentifier();
        $can_patch = $access->hasExecutable('patch');
Severity: Minor
Found in src/Application/Tiki.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Restore has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class Restore extends Backup
{
    const CLONE_PROCESS = 'clone';
    const RESTORE_PROCESS = 'restore';
Severity: Minor
Found in src/Application/Restore.php - About 3 hrs to fix

    Method setupDatabase has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function setupDatabase(Instance $instance, $reconfigure = false): Instance
    {
        try {
            if (!$reconfigure && $this->testExistingDbConnection($instance)) {
                return $instance;
    Severity: Major
    Found in src/Command/Traits/InstanceConfigure.php - About 3 hrs to fix

      Function readManifest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public function readManifest($manifestPath)
    {
        $access = $this->getAccess();

        if ($this->direct && $this->source->type == 'local') {
      Severity: Minor
      Found in src/Application/Restore.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Application has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class Application
{
    protected $instance;

    /** @var TikiManagerStyle $io */
      Severity: Minor
      Found in src/Application/Application.php - About 3 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function detectBackupPerm($path): array
    {
        $user = $group = [];

        if (extension_loaded('posix')) {
        Severity: Major
        Found in src/Application/Discovery/MacOSDiscovery.php and 1 other location - About 3 hrs to fix
        src/Application/Discovery/LinuxDiscovery.php on lines 97..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function detectBackupPerm($path): array
    {
        $user = $group = [];

        if (extension_loaded('posix')) {
        Severity: Major
        Found in src/Application/Discovery/LinuxDiscovery.php and 1 other location - About 3 hrs to fix
        src/Application/Discovery/MacOSDiscovery.php on lines 96..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method restore has 87 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function restore($srcInstance, $archive, $clone = false, $checksumCheck = false, $direct = false, $onlyData = false, $onlyCode = false, $options = [])
    {
        $restore = new Restore($this, $direct, $onlyData);
        $restore->lock();
        $restore->setProcess($clone);
        Severity: Major
        Found in src/Application/Instance.php - About 3 hrs to fix

          Function getSVNPath has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getSVNPath()
    {
        $host = $this->getHost();

        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
          Severity: Minor
          Found in src/Access/Local.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File Database.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
// Copyright (c) 2016, Avan.Tech, et. al.
// Copyright (c) 2008, Luis Argerich, Garland Foster, Eduardo Polidor, et. al.
// All Rights Reserved. See copyright.txt for details and a complete list of authors.
// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See license.txt for details.
          Severity: Minor
          Found in src/Libs/Database/Database.php - About 3 hrs to fix

            The class SSH has an overall complexity of 77 which is very high. The configured complexity threshold is 50.
            Open

            class SSH extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $changeLocation = null;
            Severity: Minor
            Found in src/Access/SSH.php by phpmd

            The class Discovery has an overall complexity of 64 which is very high. The configured complexity threshold is 50.
            Open

            abstract class Discovery
{
    protected $access;
    protected $instance;
    protected $config;
            Severity: Minor
            Found in src/Application/Discovery.php by phpmd

            The class Application has 14 public methods. Consider refactoring Application to keep number of public methods under 10.
            Open

            abstract class Application
{
    protected $instance;

    /** @var TikiManagerStyle $io */
            Severity: Minor
            Found in src/Application/Application.php by phpmd

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            The class Local has 18 public methods. Consider refactoring Local to keep number of public methods under 10.
            Open

            class Local extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $hostlib = null;
            Severity: Minor
            Found in src/Access/Local.php by phpmd

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            The class SSH has 18 public methods. Consider refactoring SSH to keep number of public methods under 10.
            Open

            class SSH extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $changeLocation = null;
            Severity: Minor
            Found in src/Access/SSH.php by phpmd

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            The class FTP has 19 public methods. Consider refactoring FTP to keep number of public methods under 10.
            Open

            class FTP extends Access implements Mountable
{
    private $lastMount;

    public function __construct(Instance $instance)
            Severity: Minor
            Found in src/Access/FTP.php by phpmd

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            The class Discovery has 13 public methods. Consider refactoring Discovery to keep number of public methods under 10.
            Open

            abstract class Discovery
{
    protected $access;
    protected $instance;
    protected $config;
            Severity: Minor
            Found in src/Application/Discovery.php by phpmd

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            Severity
            Category
            Status
            Source
            Language