Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star

Showing 2,255 of 2,255 total issues

Application has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Application
{
    protected $instance;

    /** @var TikiManagerStyle $io */
Severity: Minor
Found in src/Application/Application.php - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public function detectBackupPerm($path): array
    {
        $user = $group = [];

        if (extension_loaded('posix')) {
    Severity: Major
    Found in src/Application/Discovery/LinuxDiscovery.php and 1 other location - About 3 hrs to fix
    src/Application/Discovery/MacOSDiscovery.php on lines 96..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 152.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public function detectBackupPerm($path): array
    {
        $user = $group = [];

        if (extension_loaded('posix')) {
    Severity: Major
    Found in src/Application/Discovery/MacOSDiscovery.php and 1 other location - About 3 hrs to fix
    src/Application/Discovery/LinuxDiscovery.php on lines 97..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 152.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method restore has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function restore($srcInstance, $archive, $clone = false, $checksumCheck = false, $direct = false, $onlyData = false, $onlyCode = false, $options = [], $skipSystemConfigurationCheck = false, $allowCommonParents = 0)
    {
        $restore = new Restore($this, $direct, $onlyData, $skipSystemConfigurationCheck, $allowCommonParents);

        $restore->lock();
    Severity: Major
    Found in src/Application/Instance.php - About 3 hrs to fix

      Function getSVNPath has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getSVNPath()
    {
        $host = $this->getHost();

        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
      Severity: Minor
      Found in src/Access/Local.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Database.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
// Copyright (c) 2016, Avan.Tech, et. al.
// Copyright (c) 2008, Luis Argerich, Garland Foster, Eduardo Polidor, et. al.
// All Rights Reserved. See copyright.txt for details and a complete list of authors.
// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See license.txt for details.
      Severity: Minor
      Found in src/Libs/Database/Database.php - About 3 hrs to fix

        File UpdateInstanceCommand.php has 306 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * @copyright (c) Copyright by authors of the Tiki Manager Project. All Rights Reserved.
 *     See copyright.txt for details and a complete list of authors.
 * @licence Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See LICENSE for details.
        Severity: Minor
        Found in src/Command/UpdateInstanceCommand.php - About 3 hrs to fix

          SSH has 28 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SSH extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $changeLocation = null;
          Severity: Minor
          Found in src/Access/SSH.php - About 3 hrs to fix

            Local has 28 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Local extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $hostlib = null;
            Severity: Minor
            Found in src/Access/Local.php - About 3 hrs to fix

              The class Local has 19 public methods. Consider refactoring Local to keep number of public methods under 10.
              Open

              class Local extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $hostlib = null;
              Severity: Minor
              Found in src/Access/Local.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class SSH has 19 public methods. Consider refactoring SSH to keep number of public methods under 10.
              Open

              class SSH extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $changeLocation = null;
              Severity: Minor
              Found in src/Access/SSH.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class SSH has an overall complexity of 85 which is very high. The configured complexity threshold is 50.
              Open

              class SSH extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $changeLocation = null;
              Severity: Minor
              Found in src/Access/SSH.php by phpmd

              The class Local has an overall complexity of 95 which is very high. The configured complexity threshold is 50.
              Open

              class Local extends Access implements ShellPrompt
{
    private $location;
    private $env = [];
    private $hostlib = null;
              Severity: Minor
              Found in src/Access/Local.php by phpmd

              The class FTP has 20 public methods. Consider refactoring FTP to keep number of public methods under 10.
              Open

              class FTP extends Access implements Mountable
{
    private $lastMount;

    public function __construct(Instance $instance)
              Severity: Minor
              Found in src/Access/FTP.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class FTP has an overall complexity of 52 which is very high. The configured complexity threshold is 50.
              Open

              class FTP extends Access implements Mountable
{
    private $lastMount;

    public function __construct(Instance $instance)
              Severity: Minor
              Found in src/Access/FTP.php by phpmd

              The class Application has 14 public methods. Consider refactoring Application to keep number of public methods under 10.
              Open

              abstract class Application
{
    protected $instance;

    /** @var TikiManagerStyle $io */
              Severity: Minor
              Found in src/Application/Application.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class Access has 16 public methods. Consider refactoring Access to keep number of public methods under 10.
              Open

              abstract class Access
{
    private $rowid;
    private $type;
    protected $instance;
              Severity: Minor
              Found in src/Access/Access.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class Discovery has 13 public methods. Consider refactoring Discovery to keep number of public methods under 10.
              Open

              abstract class Discovery
{
    protected $access;
    protected $instance;
    protected $config;
              Severity: Minor
              Found in src/Application/Discovery.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class Discovery has an overall complexity of 64 which is very high. The configured complexity threshold is 50.
              Open

              abstract class Discovery
{
    protected $access;
    protected $instance;
    protected $config;
              Severity: Minor
              Found in src/Application/Discovery.php by phpmd

              The class Instance has 29 non-getter- and setter-methods. Consider refactoring Instance to keep number of methods under 25.
              Open

              class Instance
{
    const TYPES = 'local,ftp,ssh';

    const SQL_SELECT_INSTANCE = <<<SQL
              Severity: Minor
              Found in src/Application/Instance.php by phpmd

              TooManyMethods

              Since: 0.1

              A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              The default was changed from 10 to 25 in PHPMD 2.3.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanymethods

              Severity
              Category
              Status
              Source
              Language