Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star

Showing 2,255 of 2,255 total issues

Command has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Command
{
    private $args;
    private $command;
    private $host;
Severity: Minor
Found in src/Libs/Host/Command.php - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $instanceId = $input->getOption('instance');
        $instance = Instance::getInstance($instanceId);
    Severity: Minor
    Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $helper = $this->getHelper('question');
        $status = $input->getArgument('status');
        $instancesOption = $input->getOption('instances');
    Severity: Minor
    Found in src/Command/MaintenanceInstanceCommand.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($this->runLocally) {
            $cmd = Process::fromShellCommandline($command, null, null, null, 1800);  // 30min tops
            $cmd->run();
            $output = $cmd->getOutput();
            $error = $cmd->getErrorOutput();
    Severity: Major
    Found in src/Libs/VersionControl/Git.php and 1 other location - About 2 hrs to fix
    src/Libs/VersionControl/Svn.php on lines 126..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($this->runLocally) {
            $cmd = Process::fromShellCommandline($command, null, null, null, 1800);  // 30min tops
            $cmd->run();
            $output = $cmd->getOutput();
            $error = $cmd->getErrorOutput();
    Severity: Major
    Found in src/Libs/VersionControl/Svn.php and 1 other location - About 2 hrs to fix
    src/Libs/VersionControl/Git.php on lines 138..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File SetupCloneManagerCommand.php has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * @copyright (c) Copyright by authors of the Tiki Manager Project. All Rights Reserved.
 *     See copyright.txt for details and a complete list of authors.
    Severity: Minor
    Found in src/Command/SetupCloneManagerCommand.php - About 2 hrs to fix

      Method execute has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
    {
        $email = $input->getOption('email');

        if (empty($email) || !filter_var($email, FILTER_VALIDATE_EMAIL)) {
      Severity: Major
      Found in src/Command/WatchInstanceCommand.php - About 2 hrs to fix

        CommandHelper has 25 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class CommandHelper
{
    /**
     * Get information from Instance Object
     *
        Severity: Minor
        Found in src/Command/Helper/CommandHelper.php - About 2 hrs to fix

          Method interact has 69 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function interact(InputInterface $input, OutputInterface $output)
    {
        $instances = CommandHelper::getInstances('tiki');
        $instances = array_filter($instances, function ($instance) {
            return $instance->vcs_type == 'git';
          Severity: Major
          Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

            Function fixPermissions has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function fixPermissions()
    {
        $instance = $this->instance;
        $access = $instance->getBestAccess('scripting');
            Severity: Minor
            Found in src/Application/Tiki.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method applyPatch has 68 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function applyPatch(Patch $patch, $options)
    {
        $access = $this->instance->getBestAccess('scripting');
        $vcsType = $this->vcs_instance->getIdentifier();
        $can_patch = $access->hasExecutable('patch');
            Severity: Major
            Found in src/Application/Tiki.php - About 2 hrs to fix

              Method execute has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
    {
        $instanceId = $input->getOption('instance');
        $instance = Instance::getInstance($instanceId);
              Severity: Major
              Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

                Discovery has 24 functions (exceeds 20 allowed). Consider refactoring.
                Open

                abstract class Discovery
{
    protected $access;
    protected $instance;
    protected $config;
                Severity: Minor
                Found in src/Application/Discovery.php - About 2 hrs to fix

                  Database has 24 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Database
{
    /** @var Instance */
    private $instance;
    private $access;
                  Severity: Minor
                  Found in src/Libs/Database/Database.php - About 2 hrs to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function setStdin($stdin)
    {
        if (is_object($stdin) && method_exists($stdin, '__toString')) {
            $stdin = strval($stdin);
        }
                    Severity: Major
                    Found in src/Libs/Host/Command.php and 2 other locations - About 2 hrs to fix
                    src/Libs/Host/Command.php on lines 253..268
                    src/Libs/Host/Command.php on lines 293..308

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 134.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function setStdout($stdout)
    {
        if (is_object($stdout) && method_exists($stdout, '__toString')) {
            $stdout = strval($stdout);
        }
                    Severity: Major
                    Found in src/Libs/Host/Command.php and 2 other locations - About 2 hrs to fix
                    src/Libs/Host/Command.php on lines 253..268
                    src/Libs/Host/Command.php on lines 273..288

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 134.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function setStderr($stderr)
    {
        if (is_object($stderr) && method_exists($stderr, '__toString')) {
            $stderr = strval($stderr);
        }
                    Severity: Major
                    Found in src/Libs/Host/Command.php and 2 other locations - About 2 hrs to fix
                    src/Libs/Host/Command.php on lines 273..288
                    src/Libs/Host/Command.php on lines 293..308

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 134.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method configure has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function configure()
    {
        parent::configure();

        $this
                    Severity: Major
                    Found in src/Command/UpgradeInstanceCommand.php - About 2 hrs to fix

                      Method isMissingPHPRequirements has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function isMissingPHPRequirements(Instance $instance, LoggerInterface $log): bool
    {
        return false;
        $missingRequirements = [];
        $access = $instance->getBestAccess();
                      Severity: Major
                      Found in src/Command/Traits/InstanceConfigure.php - About 2 hrs to fix

                        Method configure has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function configure()
    {
        parent::configure();

        $this
                        Severity: Major
                        Found in src/Command/EditInstanceCommand.php - About 2 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language