Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star

Showing 1,426 of 1,426 total issues

The method flatten uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $result[$parentKey.$key] = $value;
            }
Severity: Minor
Found in src/Contest/ContestParticipationCsvData.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'contest'.
Open

            Uuid::fromString($quizId)
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method fromContestParticipation uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $address = new AddressEmbeddable(
                '',
                '',
                '',
Severity: Minor
Found in src/Contest/Repositories/Entities/ContestParticipationEntity.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __construct has 11 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct(
        UuidInterface $id,
        Year $year,
        Language $language,
        QuizChannel $channel,
Severity: Minor
Found in src/Contest/Models/ContestParticipation.php by phpmd

Avoid using static access to class '\Symfony\Component\Yaml\Yaml' in method '__construct'.
Open

        $this->tieBreakersAsYaml = Yaml::parseFile($tieBreakersFile);
Severity: Minor
Found in src/Contest/Repositories/TieBreakerYamlRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\User\ValueObjects\Password' in method 'resetPassword'.
Open

                $user = $user->withPassword(Password::fromPlainText($data['password']));
Severity: Minor
Found in src/Account/Controllers/AccountViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        else {
            $output->writeln('Cleaning Redis...');
            $redis->flushDB();
        }
Severity: Minor
Found in src/Command/CleanReadModelsCommand.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'createCategoriesFromYml'.
Open

                        Uuid::fromString($categoryAsYml['id']),
Severity: Minor
Found in src/Command/SeedCategoriesCommand.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'convertNullToString'.
Open

    private function convertNullToString($value)
    {
        if ($value === null) {
            return '';
        }
Severity: Minor
Found in src/Common/CsvResponse.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'exportCupTeam'.
Open

        $teamId = Uuid::fromString($teamId);
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toContestParticipation'.
Open

            Uuid::fromString($this->getId()),
Severity: Minor
Found in src/Contest/Repositories/Entities/ContestParticipationEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method redirectToLandingPage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $this->redirectToRoute('dashboard');
        }
Severity: Minor
Found in src/Account/Controllers/AccountViewController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'VSV\GVQ_API\Contest\Repositories\Entities\ContestParticipantEmbeddable' in method 'fromContestParticipation'.
Open

            ContestParticipantEmbeddable::fromContestParticipation(
                $contestParticipation->getContestParticipant()
            ),
Severity: Minor
Found in src/Contest/Repositories/Entities/ContestParticipationEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $output->writeln('Value found for key');
        }
Severity: Minor
Found in src/Command/RedisCommand.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method contest() contains an exit expression.
Open

            exit;
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Avoid using static access to class '\VSV\GVQ_API\Contest\Repositories\Entities\ContestParticipationEntity' in method 'save'.
Open

        $contestParticipantEntity = ContestParticipationEntity::fromContestParticipation($contestParticipation);
Severity: Minor
Found in src/Contest/Repositories/ContestParticipationDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct(
        TranslatorInterface $translator,
        UuidFactoryInterface $uuidFactory,
        UserRepository $userRepository,
        CompanyRepository $companyRepository,
Severity: Minor
Found in src/Account/Controllers/AccountViewController.php by phpmd

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Company/Serializers/CompanyDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\User\Repositories\Entities\UserEntity' in method 'fromCompany'.
Open

            UserEntity::fromUser($company->getUser()),
Severity: Minor
Found in src/Company/Repositories/Entities/CompanyEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'contest'.
Open

        if ($this->contestService->hasParticipatedBefore($this->year, Uuid::fromString($quizId))) {
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language