Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star

Showing 1,426 of 1,426 total issues

Avoid using static access to class '\VSV\GVQ_API\User\Repositories\Entities\UserEntity' in method 'getAllByUser'.
Open

                'userEntity' => UserEntity::fromUser($user),
Severity: Minor
Found in src/Company/Repositories/CompanyDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct(
        Year $year,
        ContestService $contestService,
        UuidFactoryInterface $uuidFactory,
        QuizRepository $quizRepository,
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'contest'.
Open

                Uuid::fromString($quizId)
Severity: Minor
Found in src/Contest/Controllers/ContestViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method buildForm() has 105 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        /** @var TranslatorInterface $translator */
        $translator = $options['translator'];
Severity: Minor
Found in src/Contest/Forms/ContestFormType.php by phpmd

The method sendKickOffMail uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $documentPath = $this->projectDir . '/public/documents/nl/'.$documentName;
        }
Severity: Minor
Found in src/Mail/Service/SwiftMailService.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toAnswer'.
Open

            Uuid::fromString($this->getId()),
Severity: Minor
Found in src/Question/Repositories/Entities/AnswerEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Partner/Serializers/PartnerDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\Question\Repositories\Entities\CategoryEntity' in method 'save'.
Open

            CategoryEntity::fromCategory($category)
Severity: Minor
Found in src/Question/Repositories/CategoryDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\Question\Repositories\Entities\QuestionEntity' in method 'save'.
Open

        $questionEntity = QuestionEntity::fromQuestion($question);
Severity: Minor
Found in src/Question/Repositories/QuestionDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method uniquePassedParticipantsPercentages uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $passedUniqueParticipantPercentage[$key] = round(
                        (float)$passedUniqueParticipantCounts[$key] / (float)$uniqueParticipantsCounts[$key],
                        2
                    ) * 100;
Severity: Minor
Found in src/Dashboard/Service/DashboardService.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'getByYearAndAlias'.
Open

                    Uuid::fromString($partnerAsYml['id']),
Severity: Minor
Found in src/Partner/Repositories/PartnerYamlRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'VSV\GVQ_API\Question\Repositories\Entities\AnswerEntity' in method 'fromQuestion'.
Open

                return AnswerEntity::fromAnswer($answer);
Severity: Minor
Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$uniqueParticipantsCount'.
Open

        foreach ($uniqueParticipantsCounts as $key => $uniqueParticipantsCount) {
Severity: Minor
Found in src/Dashboard/Service/DashboardService.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\Swift_Attachment' in method 'sendKickOffMail'.
Open

        $message->attach(Swift_Attachment::fromPath($documentPath));
Severity: Minor
Found in src/Mail/Service/SwiftMailService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'getTextTemplate'.
Open

    private function getTextTemplate(Language $language, string $templateName): string
    {
        return 'mails/'.$templateName.'.'.$language->toNative().'.text.twig';
    }
Severity: Minor
Found in src/Mail/Service/SwiftMailService.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

The method print uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $questionsArray = $questions->toArray();
            }
Severity: Minor
Found in src/Question/Controllers/QuestionViewController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\VSV\GVQ_API\Question\Repositories\Entities\CategoryEntity' in method 'update'.
Open

            CategoryEntity::fromCategory($category)
Severity: Minor
Found in src/Question/Repositories/CategoryDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'VSV\GVQ_API\Question\Repositories\Entities\CategoryEntity' in method 'fromQuestion'.
Open

            CategoryEntity::fromCategory($question->getCategory()),
Severity: Minor
Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toQuestion'.
Open

            Uuid::fromString($this->getId()),
Severity: Minor
Found in src/Question/Repositories/Entities/QuestionEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Broadway\Domain\DateTime' in method 'createDomainMessage'.
Open

            DateTime::fromString($eventEntity->getRecordedOn())
Severity: Minor
Found in src/Quiz/EventStore/DoctrineEventStore.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language