Sign upLogin

VSVverkeerskunde/gvq-api

View on GitHub
Star

Showing 1,426 of 1,426 total issues

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'getAllByYear'.
Open

                Uuid::fromString($partnerAsYml['id']),
Severity: Minor
Found in src/Partner/Repositories/PartnerYamlRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method updateQuestionFromData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $id = $uuidFactory->uuid4();
            }
Severity: Minor
Found in src/Question/Forms/QuestionFormType.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Question/Serializers/QuestionDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getTraversableDomainMessages uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $queryBuilder->where(
                    $queryBuilder->expr()->gte('e.id', $nextId)
                );
            }
Severity: Minor
Found in src/Quiz/EventStore/DoctrineEventStore.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\VSV\GVQ_API\Quiz\Aggregate\QuizAggregate' in method 'start'.
Open

        $quizAggregate = QuizAggregate::start($quiz);
Severity: Minor
Found in src/Quiz/Controllers/QuizController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Symfony\Component\Yaml\Yaml' in method '__construct'.
Open

        $this->partnersAsYml = Yaml::parseFile($partnerFile);
Severity: Minor
Found in src/Partner/Repositories/PartnerYamlRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\Question\Repositories\Entities\CategoryEntity' in method 'delete'.
Open

            CategoryEntity::fromCategory($category)
Severity: Minor
Found in src/Question/Repositories/CategoryDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'toCategory'.
Open

            Uuid::fromString($this->getId()),
Severity: Minor
Found in src/Question/Repositories/Entities/CategoryEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Symfony\Component\Yaml\Yaml' in method 'showQuiz'.
Open

            $teams = Yaml::parseFile(
                $container->getParameter('kernel.project_dir') . '/config/teams.yaml'
            );
Severity: Minor
Found in src/Quiz/Controllers/QuizViewController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Quiz/Serializers/AnsweredCorrectDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Quiz/Serializers/QuizFinishedDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\Statistics\Repositories\Entities\DetailedTopScoreEntity' in method 'saveWhenHigher'.
Open

            DetailedTopScoreEntity::fromDetailedTopScore($detailedTopScore)
Severity: Minor
Found in src/Statistics/Repositories/DetailedTopScoreDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\Statistics\Repositories\Entities\TeamParticipantEntity' in method 'save'.
Open

        $this->entityManager->persist(TeamParticipantEntity::fromTeamParticipant($teamParticipant));
Severity: Minor
Found in src/Statistics/Repositories/TeamParticipantDoctrineRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\VSV\GVQ_API\User\Repositories\Entities\UserEntity' in method 'fromRegistration'.
Open

            UserEntity::fromUser($registration->getUser()),
Severity: Minor
Found in src/Registration/Repositories/Entities/RegistrationEntity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'denormalize'.
Open

            Uuid::fromString($data['id']),
Severity: Minor
Found in src/Quiz/Serializers/QuizStartedDenormalizer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method createOverallTotalFromQuiz uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $statisticsKey = self::OVERALL_FR;
        }
Severity: Minor
Found in src/Quiz/ValueObjects/StatisticsKey.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\VSV\GVQ_API\Quiz\ValueObjects\StatisticsKey' in method 'handle'.
Open

                $overallTotalStatisticsKey = StatisticsKey::createOverallTotalFromQuiz($quiz);
Severity: Minor
Found in src/Statistics/Projectors/UniqueParticipantProjector.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'getRange'.
Open

            $question = $this->questionRepository->getById(Uuid::fromString($questionId));
Severity: Minor
Found in src/Statistics/Repositories/QuestionDifficultyRedisRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ramsey\Uuid\Uuid' in method 'generateQuestions'.
Open

            $firstQuestion = $this->questionRepository->getById(Uuid::fromString($firstQuestionId));
Severity: Minor
Found in src/Quiz/Service/QuizService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method canViewReport uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // Security on the route is still in place.
            // So this point is admin or vsv role.
            return true;
        }
Severity: Minor
Found in src/Report/Controllers/ReportViewController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language