Sign upLogin

VandyHacks/vaken

View on GitHub
Star
src/server/resolvers/MutationResolvers/updateApplicationResolver.ts

Summary

Maintainability
A
1 hr
Test Coverage
F
20%

Function updateMyApplication has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Confirmed

export const updateMyApplication: MutationResolvers['updateMyApplication'] = async (
    root,
    { input },
    { user, models }
) => {
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

    // TODO: Improve the quality of this resolver by removing this hack.
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts by fixme

TODO found
Open

        // TODO: Add input validation for these fields.
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts by fixme

TODO found
Open

        // TODO: These are not typechecked currently :/
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts by fixme

TODO found
Open

// TODO: Cannot import frontend files so this is ugly workaround. Fix this.
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts by fixme

TODO found
Open

    // TODO(leonm1): Figure out why the _id field isn't actually an ObjectID
Severity: Minor
Found in src/server/resolvers/MutationResolvers/updateApplicationResolver.ts by fixme

There are no issues that match your filters.

Category
Status