Sign upLogin

Verites/verigraph

View on GitHub
Star

Showing 188 of 188 total issues

Use tuple-section
Open

    newNames = map (\number -> (fstName, sndName, number)) ([0..] :: [Int])
Severity: Minor
Found in src/library/Analysis/Interlevel/InterLevelCP.hs by hlint

Found

\ number -> (fstName, sndName, number)

Perhaps

(fstName, sndName,)

Applying this change:

  • may require {-# LANGUAGE TupleSections #-} adding to the top of the file

Use list comprehension
Open

    attrInfo = if info == "" then [] else [sattr "info" ("NAC:"++info)]
Severity: Minor
Found in src/library/XML/GGXWriter.hs by hlint

Found

if info == "" then [] else [sattr "info" ("NAC:" ++ info)]

Perhaps

[sattr "info" ("NAC:" ++ info) | not (info == "")]

Use void
Open

mapMCollectErrors_ fn xs = mapMCollectErrors fn xs >> return ()
Severity: Minor
Found in src/library/Util/Monad.hs by hlint

Found

mapMCollectErrors fn xs >> return ()

Perhaps

void (mapMCollectErrors fn xs)

Use tuple-section
Open

                    (\name -> (id,name))
Severity: Minor
Found in src/library/XML/ParseSndOrderRule.hs by hlint

Found

\ name -> (id, name)

Perhaps

(id,)

Applying this change:

  • may require {-# LANGUAGE TupleSections #-} adding to the top of the file

Use infix
Open

    (ruleTyping,typeNo) = partition (\((_,_,label),_) -> isPrefixOf "type:" label) removedIgnoredLabels
Severity: Minor
Found in src/library/XML/GPRReader/GXLPreProcessing.hs by hlint

Found

isPrefixOf "type:" label

Perhaps

"type:" `isPrefixOf` label

Use $>
Open

      (reserved "A" *> pure A) <|> (reserved "E" *> pure E) <?> "temporal quantifier"
Severity: Minor
Found in src/library/Logic/Ctl/Parser.hs by hlint

Found

reserved "A" *> pure A

Perhaps

reserved "A" Data.Functor.$> A

Use $>
Open

  <|> (reserved "AF" *> pure (A . F))
Severity: Minor
Found in src/library/Logic/Ctl/Parser.hs by hlint

Found

reserved "AF" *> pure (A . F)

Perhaps

reserved "AF" Data.Functor.$> (A . F)

Use tuple-section
Open

expandeProductions (a,b) = map (\x -> (a,x)) (expandNACs b)
Severity: Minor
Found in src/library/Analysis/Processes.hs by hlint

Found

\ x -> (a, x)

Perhaps

(a,)

Applying this change:

  • may require {-# LANGUAGE TupleSections #-} adding to the top of the file

Redundant bracket
Open

    (nonPreservNodes,edgs) = partition (\((_,_,label),_) -> (label `elem` specialLabels)) typeNo
Severity: Minor
Found in src/library/XML/GPRReader/GXLPreProcessing.hs by hlint

Found

\ ((_, _, label), _) -> (label `elem` specialLabels)

Perhaps

\ ((_, _, label), _) -> label `elem` specialLabels

TODO found
Open

-- TODO: move this to XML parsing module
Severity: Minor
Found in src/library/Image/Dot/TypedGraph.hs by fixme

TODO found
Open

-- | TODO: use Data.Set?
Severity: Minor
Found in src/library/Data/TypedGraph/Partition/Types.hs by fixme

TODO found
Open

  -- TODO: implement missing methods of Config for RuleMorphism
Severity: Minor
Found in src/library/Category/TypedGraphRule/Limit.hs by fixme

TODO found
Open

-- TODO: this function should not be here in this module
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by fixme

TODO found
Open

  -- TODO: write export list explicitly
Severity: Minor
Found in src/library/Data/TypedGraph/Morphism.hs by fixme

TODO found
Open

        -- TODO: replace explicit test cases with pseudo-random generation
Severity: Minor
Found in tests/GrLang/CompilerSpec.hs by fixme

TODO found
Open

  -- TODO: document why minimal safety NACs exist
Severity: Minor
Found in src/library/Rewriting/DPO/TypedGraphRule.hs by fixme

TODO found
Open

        -- TODO: replace explicit test cases with pseudo-random generation
Severity: Minor
Found in tests/GrLang/CompilerSpec.hs by fixme

FIXME found
Open

  -- FIXME: rethink this function and the best module to place it
Severity: Minor
Found in src/library/Abstract/Rewriting/DPO.hs by fixme

TODO found
Open

-- TODO: this function should not be here in this module
Severity: Minor
Found in src/library/Category/TypedGraph/Adhesive.hs by fixme

TODO found
Open

        -- TODO: error handling for XML writes
Severity: Minor
Found in src/CLI/CriticalPairAnalysis.hs by fixme
Severity
Category
Status
Source
Language