Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star

Showing 1,213 of 1,213 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.brush = d3.svg
          .brush()
          .x(this.xscale)
          .extent([0, 0])
          .on('brush', function() {
Severity: Major
Found in app/assets/javascripts/abstract/timeline/TimelineMonthClass.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/abstract/timeline/TimelineMonthClass.js on lines 425..434

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        var contentGroup = averageContent
          .selectAll('g')
          .data(this.averageData)
          .enter()
          .append('g')
Severity: Major
Found in app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js and 2 other locations - About 2 hrs to fix
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 356..366
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 521..531

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          case 'subnational':
            if (
              !!widgets &&
              !!jurisdictions &&
              Object.keys(jurisdictions).length > 0
Severity: Major
Found in app/assets/javascripts/countries/views/show/WidgetGridView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/show/WidgetGridView.js on lines 72..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        var provincesGroup = provincesContent
          .selectAll('g')
          .data(this.chartData)
          .enter()
          .append('g')
Severity: Major
Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 2 other locations - About 2 hrs to fix
app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 817..827
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 521..531

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        var barGroup = barsContent
          .selectAll('g')
          .data(this.chartData)
          .enter()
          .append('g')
Severity: Major
Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 2 other locations - About 2 hrs to fix
app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 817..827
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 356..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        deviationGroup = deviationContent
          .selectAll('g')
          .data(this.chartData)
          .enter()
          .append('g')
Severity: Major
Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 398..408

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          case 'areas-interest':
            if (!!widgets && !!areas && Object.keys(areas).length > 0) {
              this.$noIndicatorsWarning.addClass('is-hidden');
              this.$moreIndicatorsWarning.removeClass('is-hidden');
            } else {
Severity: Major
Found in app/assets/javascripts/countries/views/show/WidgetGridView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/show/WidgetGridView.js on lines 59..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        lossGroup = lossContent
          .selectAll('g')
          .data(this.chartData)
          .enter()
          .append('g')
Severity: Major
Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 470..480

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

define(['mps', 'backbone', 'jquery'], function(mps, Backbone, $) {
  var CountryModel = Backbone.Model.extend({
    url: '/api/countries/',

    initialize: function(setup) {
Severity: Major
Found in app/assets/javascripts/countries/models/CountryModel.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/embed/models/CountryModel.js on lines 1..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

define(['mps', 'backbone', 'jquery'], function(mps, Backbone, $) {
  var CountryModel = Backbone.Model.extend({
    url: '/api/countries/',

    initialize: function(setup) {
Severity: Major
Found in app/assets/javascripts/embed/models/CountryModel.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/countries/models/CountryModel.js on lines 1..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      defaults: {
        selectedClassEl: '-selected',
        filter: 'carbon_emissions',
        country: '',
        year: 2018,
Severity: Major
Found in app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/views/InsightsGladAlertsView.js on lines 42..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    defaults: {
      selectedClassEl: '-selected',
      filter: 'carbon_emissions',
      country: '',
      year: 2017,
Severity: Major
Found in app/assets/javascripts/insights/views/InsightsGladAlertsView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsView.js on lines 58..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _setMarker has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      _setMarker: function(stories) {
        this.infowindows = [];

        this.markers = _.map(
          stories,
Severity: Major
Found in app/assets/javascripts/abstract/layer/MarkersLayerClass.js - About 2 hrs to fix

    Function draw has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        draw: function(topology, el, params) {
      if (!topology) {
        console.warn('topology is necessary');
        return null;
      } else if (!el) {
    Severity: Major
    Found in app/assets/javascripts/helpers/CountryHelper.js - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      return _this.circles
                  .each(_this.mandatorySort(e.alpha))
                  .each(_this.buoyancy(e.alpha))
                  .attr('cx', function(d) {
                    return d.x;
      Severity: Major
      Found in app/assets/javascripts/countries/views/pantropical/vis.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/countries/views/pantropical/vis.js on lines 495..503

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    return _this.circles
                .each(_this.mandatorySort(e.alpha))
                .each(_this.buoyancy(e.alpha))
                .attr('cx', function(d) {
                  return d.x;
      Severity: Major
      Found in app/assets/javascripts/countries/views/pantropical/vis.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/countries/views/pantropical/vis.js on lines 434..442

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File SearchboxView.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * The Searchbox module.
 *
 * @return searchbox class (extends Backbone.View).
 */
      Severity: Minor
      Found in app/assets/javascripts/map/views/controls/SearchboxView.js - About 2 hrs to fix

        Function _renderLegend has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _renderLegend: function(categories, options, geographic) {
      var iso = null;
      var layersGlobal = [];
      var layersIso = [];
      var categoriesGlobal = [];
        Severity: Major
        Found in app/assets/javascripts/map/views/LegendView.js - About 2 hrs to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              StackedChart.prototype._createEl = function() {
      this.svg = d3
        .select(this.options.el)
        .append('svg')
        .attr('class', 'lineChart')
          Severity: Major
          Found in app/assets/javascripts/widgets/indicators/stacked/StackedChart.js and 2 other locations - About 2 hrs to fix
          app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 66..73
          app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 62..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              LineChart.prototype._createEl = function() {
      this.svg = d3
        .select(this.options.el)
        .append('svg')
        .attr('class', 'lineChart')
          Severity: Major
          Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js and 2 other locations - About 2 hrs to fix
          app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 66..73
          app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 64..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language