Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star

Showing 1,213 of 1,213 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = true;
Severity: Major
Found in app/assets/javascripts/map/views/MapView.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/map/views/MapView.js on lines 76..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getCountry has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      getCountry: function(params, statsOption) {
        var stats = statsOption || false;
        var datasetId =
          GET_REQUEST_COUNTRY_ID + '_' + params.iso + '_' + stats
            ? 'withStats'
Severity: Major
Found in app/assets/javascripts/services/CountryService.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            this.trail
          .call(this.hiddenBrush.event)
          .transition()
          .duration(speed)
          .ease('line')
    Severity: Major
    Found in app/assets/javascripts/abstract/timeline/TimelineYearClass.js and 1 other location - About 2 hrs to fix
    app/assets/javascripts/abstract/timeline/TimelineMonthClass.js on lines 604..610

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            this.trail
          .call(this.hiddenBrush.event)
          .transition()
          .duration(speed)
          .ease('line')
    Severity: Major
    Found in app/assets/javascripts/abstract/timeline/TimelineMonthClass.js and 1 other location - About 2 hrs to fix
    app/assets/javascripts/abstract/timeline/TimelineYearClass.js on lines 447..453

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      function(_, Handlebars, MarkersLayerClass, InfoamazoniaStoryService) {
    'use strict';

    var InfoamazoniaStoriesLayer = MarkersLayerClass.extend({
      service: InfoamazoniaStoryService,
    Severity: Major
    Found in app/assets/javascripts/map/views/layers/InfoamazoniaStoriesLayer.js and 1 other location - About 2 hrs to fix
    app/assets/javascripts/map/views/layers/MongabayStoriesLayer.js on lines 12..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      function(_, MarkersLayerClass, MongabayStoryService) {
    'use strict';

    var MongabayStoriesLayer = MarkersLayerClass.extend({
      service: MongabayStoryService,
    Severity: Major
    Found in app/assets/javascripts/map/views/layers/MongabayStoriesLayer.js and 1 other location - About 2 hrs to fix
    app/assets/javascripts/map/views/layers/InfoamazoniaStoriesLayer.js on lines 13..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method get_province_vals_for has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_province_vals_for(data, indicator)

    values = data.select do |t|
      t["boundary_code"] == @use_boundary &&
        t["indicator_id"] == indicator &&
    Severity: Minor
    Found in app/models/country_report.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _drawLoss has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          _drawLoss: function() {
        var lossGroup = this.svg.select('.loss');
        var lossLabel = _.findWhere(this.defaults.labels, { slug: 'loss' });
        var lossLabelWidth = lossLabel.width * this.cWidthGrid / 100;
        var lossContent = this.svg
    Severity: Major
    Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js - About 2 hrs to fix

      Function _drawGrid has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _drawGrid: function() {
        // X Lines
        var numLines = this.chartData.length;
        var rowOffset = this.defaults.rowHeight;
        var linesGroup = this.svg
      Severity: Major
      Found in app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js - About 2 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                this.trail = this.tipsy
          .append('svg:line')
          .attr('class', 'trail')
          .attr('x1', this.handlers.right.attr('x'))
          .attr('x2', this.handlers.right.attr('x'))
        Severity: Major
        Found in app/assets/javascripts/abstract/timeline/TimelineMonthClass.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/abstract/timeline/TimelineYearClass.js on lines 346..352

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                var format = self.unit != 'percentage' ? '.3s' : '.2f',
          xyear = self.x(d.year),
          year = formatDate(d.year),
          value = d3.format(format)(d.value) + ' ' + self.unitname;
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/line/LineChart.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 291..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            LineChart.prototype._createDefs = function() {
      this.svg
        .append('defs')
        .append('clipPath')
        .attr('id', 'clip')
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/line/LineChart.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 104..112
        app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 139..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            LineChart.prototype._createDefs = function() {
      this.svg
        .append('defs')
        .append('clipPath')
        .attr('id', 'clip')
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 114..122
        app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 139..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            StackedChart.prototype._createDefs = function() {
      this.svg
        .append('defs')
        .append('clipPath')
        .attr('id', 'clip')
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/stacked/StackedChart.js and 2 other locations - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 114..122
        app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js on lines 104..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                this.trail = this.tipsy
          .append('svg:line')
          .attr('class', 'trail')
          .attr('x1', this.handlers.right.attr('x'))
          .attr('x2', this.handlers.right.attr('x'))
        Severity: Major
        Found in app/assets/javascripts/abstract/timeline/TimelineYearClass.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/abstract/timeline/TimelineMonthClass.js on lines 400..406

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  var format = self.unit != 'percentage' ? '.3s' : '.2f',
            xyear = self.x(d.year),
            year = formatDate(d.year),
            value = d3.format(format)(d.value) + ' ' + self.unitname;
        Severity: Major
        Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 277..280

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function onCountryChange has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              onCountryChange: function(selection) {
        var jurisIndex = this.filterIndex.jurisdiction_ids;
        var aoiIndex = this.filterIndex.area_ids;
        var jurisView = this.filterViews[jurisIndex];
        var aoiView = this.filterViews[aoiIndex];
        Severity: Major
        Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              var StatusModel = Backbone.Model.extend({
      defaults: {
        baselayer: null,
        both: false,
        resource: null, // analysis resource
          Severity: Major
          Found in app/assets/javascripts/map/presenters/tabs/AnalysisPresenter.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/map/presenters/tabs/SubscriptionPresenter.js on lines 29..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                _initChart: function() {
        // Data parsing and initialization
        this._parseData();
        this.hasData = this.chartData && this.chartData.length;
          Severity: Major
          Found in app/assets/javascripts/countries/views/report/ProvincesTopChartView.js and 2 other locations - About 2 hrs to fix
          app/assets/javascripts/countries/views/report/PieChartView.js on lines 52..62
          app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 57..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                _updatePlace: function() {
        var route, params;
        params = this._destandardizeParams(
          this._getPresenterParams(this._presenters)
        );
          Severity: Major
          Found in app/assets/javascripts/embed/services/PlaceService.js and 3 other locations - About 2 hrs to fix
          app/assets/javascripts/compare/services/PlaceService.js on lines 103..111
          app/assets/javascripts/map/services/PlaceService.js on lines 123..131
          app/assets/javascripts/services/PlaceService.js on lines 106..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language