Sign upLogin

WP-API/WP-API

View on GitHub
Star

Showing 244 of 244 total issues

Method prepare_item_for_response has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function prepare_item_for_response( $user, $request ) {

        $data = array();
        $schema = $this->get_item_schema();
        if ( ! empty( $schema['properties']['id'] ) ) {
Severity: Major
Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

    Method prepare_item_for_response has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function prepare_item_for_response( $post, $request ) {

        $schema = $this->get_item_schema();

        $data = array();
    Severity: Major
    Found in lib/endpoints/class-wp-rest-revisions-controller.php - About 2 hrs to fix

      Method get_item_schema has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_item_schema() {

        $schema = parent::get_item_schema();

        $schema['properties']['alt_text'] = array(
      Severity: Major
      Found in lib/endpoints/class-wp-rest-attachments-controller.php - About 2 hrs to fix

        Method create_item has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function create_item( $request ) {
        if ( ! empty( $request['id'] ) ) {
            return new WP_Error( 'rest_post_exists', __( 'Cannot create existing post.' ), array( 'status' => 400 ) );
        }
        Severity: Major
        Found in lib/endpoints/class-wp-rest-posts-controller.php - About 2 hrs to fix

          Function create_item has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function create_item( $request ) {

        if ( ! empty( $request['post'] ) && in_array( get_post_type( $request['post'] ), array( 'revision', 'attachment' ), true ) ) {
            return new WP_Error( 'rest_invalid_param', __( 'Invalid parent type.' ), array( 'status' => 400 ) );
        }
          Severity: Minor
          Found in lib/endpoints/class-wp-rest-attachments-controller.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function prepare_item_for_response has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function prepare_item_for_response( $user, $request ) {

        $data = array();
        $schema = $this->get_item_schema();
        if ( ! empty( $schema['properties']['id'] ) ) {
          Severity: Minor
          Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function prepare_links has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function prepare_links( $post ) {
        $base = sprintf( '%s/%s', $this->namespace, $this->rest_base );

        // Entity meta.
        $links = array(
          Severity: Minor
          Found in lib/endpoints/class-wp-rest-posts-controller.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_item_schema has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_item_schema() {
        $schema = array(
            '$schema'              => 'http://json-schema.org/draft-04/schema#',
            'title'                => 'taxonomy',
            'type'                 => 'object',
          Severity: Major
          Found in lib/endpoints/class-wp-rest-taxonomies-controller.php - About 2 hrs to fix

            Method prepare_item_for_database has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function prepare_item_for_database( $request ) {
        $prepared_comment = array();

        /**
         * Allow the comment_content to be set via the 'content' or
            Severity: Major
            Found in lib/endpoints/class-wp-rest-comments-controller.php - About 2 hrs to fix

              Function exports has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function( grunt ) {

    'use strict';
    var banner = '/**\n * <%= pkg.homepage %>\n * Copyright (c) <%= grunt.template.today("yyyy") %>\n * This file is generated automatically. Do not edit.\n */\n';
    require('phplint').gruntPlugin(grunt);
              Severity: Major
              Found in Gruntfile.js - About 2 hrs to fix

                Method get_collection_params has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function get_collection_params() {
        $query_params = parent::get_collection_params();

        $query_params['context']['default'] = 'view';
                Severity: Major
                Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

                  Method create_item has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function create_item( $request ) {
        if ( ! empty( $request['id'] ) ) {
            return new WP_Error( 'rest_user_exists', __( 'Cannot create existing resource.' ), array( 'status' => 400 ) );
        }
                  Severity: Major
                  Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

                    Method update_item has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function update_item( $request ) {
        $id = (int) $request['id'];
        $post = $this->get_post( $id );

        if ( empty( $id ) || empty( $post->ID ) || $this->post_type !== $post->post_type ) {
                    Severity: Major
                    Found in lib/endpoints/class-wp-rest-posts-controller.php - About 2 hrs to fix

                      File class-wp-rest-revisions-controller.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

class WP_REST_Revisions_Controller extends WP_REST_Controller {

    private $parent_post_type;
                      Severity: Minor
                      Found in lib/endpoints/class-wp-rest-revisions-controller.php - About 2 hrs to fix

                        Function get_items has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function get_items( $request ) {

        // Retrieve the list of registered collection query parameters.
        $registered = $this->get_collection_params();
                        Severity: Minor
                        Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get_filename_from_disposition has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function get_filename_from_disposition( $disposition_header ) {
        // Get the filename.
        $filename = null;

        foreach ( $disposition_header as $value ) {
                        Severity: Minor
                        Found in lib/endpoints/class-wp-rest-attachments-controller.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get_registered_fields has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function get_registered_fields() {
        $registered = array();

        foreach ( get_registered_meta_keys( $this->get_meta_type() ) as $name => $args ) {
            if ( empty( $args['show_in_rest'] ) ) {
                        Severity: Minor
                        Found in lib/fields/class-wp-rest-meta-fields.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method register_routes has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function register_routes() {

        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            array(
                'methods'         => WP_REST_Server::READABLE,
                        Severity: Major
                        Found in lib/endpoints/class-wp-rest-users-controller.php - About 2 hrs to fix

                          Method get_item_schema has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function get_item_schema() {
        $schema = array(
            '$schema'              => 'http://json-schema.org/draft-04/schema#',
            'title'                => 'status',
            'type'                 => 'object',
                          Severity: Minor
                          Found in lib/endpoints/class-wp-rest-post-statuses-controller.php - About 2 hrs to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public function get_items_permissions_check( $request ) {
        $tax_obj = get_taxonomy( $this->taxonomy );
        if ( ! $tax_obj || ! $this->check_is_taxonomy_allowed( $this->taxonomy ) ) {
            return false;
        }
                            Severity: Major
                            Found in lib/endpoints/class-wp-rest-terms-controller.php and 1 other location - About 1 hr to fix
                            lib/endpoints/class-wp-rest-terms-controller.php on lines 317..326

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 120.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language